From: Miao Xie <miaox@cn.fujitsu.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/7] Btrfs: remove unnecessary initialization and memory barrior in shrink_delalloc()
Date: Wed, 06 Nov 2013 09:39:57 +0800 [thread overview]
Message-ID: <52799DED.8090209@cn.fujitsu.com> (raw)
In-Reply-To: <20131105114516.GG16662@twin.jikos.cz>
On Tue, 5 Nov 2013 12:45:16 +0100, David Sterba wrote:
> On Mon, Nov 04, 2013 at 11:13:20PM +0800, Miao Xie wrote:
>> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
>
> Reviewed-by: David Sterba <dsterba@suse.cz>
>
> Would be nice to say why it's safe to remove the barrier. The percpu
> counters do not need it, they use a spinlock. The barrier was there due
> to access to fs_info->delalloc_bytes that was removed in commit
> 963d678b0f764930 that introduced the percpu counters.
>
Right, I'll send a new one.
Thanks for you review.
Miao
next prev parent reply other threads:[~2013-11-06 1:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 15:13 [PATCH 0/7] Btrfs: improve the latency of the space reservation Miao Xie
2013-11-04 15:13 ` [PATCH 1/7] Btrfs: remove unnecessary initialization and memory barrior in shrink_delalloc() Miao Xie
2013-11-05 11:45 ` David Sterba
2013-11-06 1:39 ` Miao Xie [this message]
2013-11-06 5:29 ` [PATCH V2 " Miao Xie
2013-11-04 15:13 ` [PATCH 2/7] Btrfs: wait for the ordered extent only when we want Miao Xie
2013-11-04 15:13 ` [PATCH 3/7] Btrfs: pick up the code for the item number calculation in flush_space() Miao Xie
2013-11-04 15:13 ` [PATCH 4/7] Btrfs: fix the confusion between delalloc bytes and metadata bytes Miao Xie
2013-11-04 15:13 ` [PATCH 5/7] Btrfs: don't wait for all the async delalloc when shrinking delalloc Miao Xie
2013-11-04 15:13 ` [PATCH 6/7] Btrfs: don't wait for the completion of all the ordered extents Miao Xie
2013-11-04 15:13 ` [PATCH 7/7] Btrfs: rename btrfs_start_all_delalloc_inodes Miao Xie
2013-11-04 17:09 ` Josef Bacik
2013-11-05 3:07 ` Miao Xie
2013-11-04 17:05 ` [PATCH 0/7] Btrfs: improve the latency of the space reservation Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52799DED.8090209@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.