From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VdyjZ-0003DQ-N8 for mharc-qemu-trivial@gnu.org; Wed, 06 Nov 2013 03:45:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdyjT-00032j-6d for qemu-trivial@nongnu.org; Wed, 06 Nov 2013 03:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdyjN-0000QS-6Y for qemu-trivial@nongnu.org; Wed, 06 Nov 2013 03:44:59 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:58884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdyjA-0000Bn-Vr; Wed, 06 Nov 2013 03:44:41 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 379454085D; Wed, 6 Nov 2013 12:44:39 +0400 (MSK) Message-ID: <527A0176.1030708@msgid.tls.msk.ru> Date: Wed, 06 Nov 2013 12:44:38 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9 MIME-Version: 1.0 To: Cole Robinson References: <1d038bb1867cd9c72ba555ab40d4c891df71c5f5.1381506642.git.crobinso@redhat.com> <5279838F.8060008@redhat.com> In-Reply-To: <5279838F.8060008@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, alex.williamson@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Subject: Re: [Qemu-trivial] [PATCH v2] pci-assign: Fix error_report of pci-stub message X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 08:45:05 -0000 > On 10/11/2013 11:52 AM, Cole Robinson wrote: >> Using multiple calls to error_report here means every line is >> prefaced with the (potentially long) pci-assign command line >> arguments. >> >> Use a single error_printf to preserve the intended formatting. >> Since this code path is always preceded by an error_report call, >> we don't lose the command line reporting. Thanks, applied to the trivial-patches queue. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdyjH-0002mX-7K for qemu-devel@nongnu.org; Wed, 06 Nov 2013 03:44:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdyjB-0000Do-7L for qemu-devel@nongnu.org; Wed, 06 Nov 2013 03:44:47 -0500 Message-ID: <527A0176.1030708@msgid.tls.msk.ru> Date: Wed, 06 Nov 2013 12:44:38 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1d038bb1867cd9c72ba555ab40d4c891df71c5f5.1381506642.git.crobinso@redhat.com> <5279838F.8060008@redhat.com> In-Reply-To: <5279838F.8060008@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] pci-assign: Fix error_report of pci-stub message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: qemu-trivial@nongnu.org, alex.williamson@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com > On 10/11/2013 11:52 AM, Cole Robinson wrote: >> Using multiple calls to error_report here means every line is >> prefaced with the (potentially long) pci-assign command line >> arguments. >> >> Use a single error_printf to preserve the intended formatting. >> Since this code path is always preceded by an error_report call, >> we don't lose the command line reporting. Thanks, applied to the trivial-patches queue. /mjt