From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] kexec: don't disable interrupts when acquiring load/unload lock Date: Wed, 6 Nov 2013 15:09:55 +0000 Message-ID: <527A5BC3.3030905@citrix.com> References: <527A428E0200007800100156@nat28.tlf.novell.com> <527A422A.6040309@citrix.com> <527A5DA60200007800100267@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ve4k3-0006tn-KR for xen-devel@lists.xenproject.org; Wed, 06 Nov 2013 15:09:59 +0000 In-Reply-To: <527A5DA60200007800100267@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Daniel Kiper , Keir Fraser , David Vrabel List-Id: xen-devel@lists.xenproject.org On 06/11/13 14:17, Jan Beulich wrote: >>>> On 06.11.13 at 14:20, David Vrabel wrote: >> On 06/11/13 12:22, Jan Beulich wrote: >>> This doesn't appear to have served any purpose other than causing >>> map_pages_to_xen() to be (incorrectly) invoked with interrupts >>> disabled. In particular, serialization against actual kexec-ing is done >>> without this lock being involved. Clarify the scope of the lock at once >>> by making it local to do_kexec_op_internal(). >>> >>> Once at it, also drop a pointless initializer. >> >> I've already dropped the irqsave from this lock in my kexec series and >> can fold the other part in as well (which would now be in >> kexec_swap_images()). > > That would generally be fine, but I'd like to get this fixed no matter > whether your patches make 4.4. Sure. I was only asking if you could wait a few days. David