From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve65k-0002st-OS for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:36:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve65e-0005LX-P9 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:36:28 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36714 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve65e-0005LN-IH for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:36:22 -0500 Message-ID: <527A5F39.2050304@suse.de> Date: Wed, 06 Nov 2013 16:24:41 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1383141276-19230-1-git-send-email-stefanha@redhat.com> <1383141276-19230-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1383141276-19230-4-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 3/7] libqtest: rename qmp() to qmp_discard_response() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster Am 30.10.2013 14:54, schrieb Stefan Hajnoczi: > Existing qmp() callers do not expect a response object. In order to > implement real QMP test cases it will be necessary to inspect the > response object. >=20 > Rename qmp() to qmp_discard_response(). Later patches will introduce a > qmp() function that returns the response object and tests that use it. >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/boot-order-test.c | 4 ++-- > tests/fdc-test.c | 15 +++++++++------ > tests/ide-test.c | 10 ++++++---- > tests/libqtest.c | 8 ++++---- > tests/libqtest.h | 20 ++++++++++---------- > 5 files changed, 31 insertions(+), 26 deletions(-) Reviewed-by: Andreas F=E4rber I notice that at least in two places [qtest_]qmp() was being called with literal "" argument. If we could get a separate qmp_wait_for_ready() or so function, then we could actually enabling format string checking for those functions. That'd a follow-up though. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg