From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve6D6-0005u5-9u for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:44:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve6Cs-0007hH-1r for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:44:04 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37748 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve6Cr-0007gz-Ox for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:43:49 -0500 Message-ID: <527A61E0.5060704@suse.de> Date: Wed, 06 Nov 2013 16:36:00 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1383141276-19230-1-git-send-email-stefanha@redhat.com> <1383141276-19230-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1383141276-19230-6-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 5/7] blockdev-test: add test case for drive_add duplicate IDs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster Am 30.10.2013 14:54, schrieb Stefan Hajnoczi: > The following should work: >=20 > (qemu) drive_add if=3Dnone,id=3Ddrive0 > (qemu) drive_del drive0 > (qemu) drive_add if=3Dnone,id=3Ddrive0 >=20 > Previous versions of QEMU produced a duplicate ID error because > drive_add leaked the options. >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/Makefile | 2 ++ > tests/blockdev-test.c | 59 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 61 insertions(+) > create mode 100644 tests/blockdev-test.c >=20 > diff --git a/tests/Makefile b/tests/Makefile > index fa4c9f0..7863123 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -67,6 +67,7 @@ check-qtest-i386-y +=3D tests/boot-order-test$(EXESUF= ) > check-qtest-i386-y +=3D tests/rtc-test$(EXESUF) > check-qtest-i386-y +=3D tests/i440fx-test$(EXESUF) > check-qtest-i386-y +=3D tests/fw_cfg-test$(EXESUF) > +check-qtest-i386-y +=3D tests/blockdev-test$(EXESUF) > check-qtest-x86_64-y =3D $(check-qtest-i386-y) > gcov-files-i386-y +=3D i386-softmmu/hw/mc146818rtc.c What's missing here is to add the source file(s) for gcov checking. But can be done as follow-up, just don't forget. :) > gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-f= iles-i386-y)) > @@ -174,6 +175,7 @@ tests/boot-order-test$(EXESUF): tests/boot-order-te= st.o $(libqos-obj-y) > tests/tmp105-test$(EXESUF): tests/tmp105-test.o $(libqos-omap-obj-y) > tests/i440fx-test$(EXESUF): tests/i440fx-test.o $(libqos-pc-obj-y) > tests/fw_cfg-test$(EXESUF): tests/fw_cfg-test.o $(libqos-pc-obj-y) > +tests/blockdev-test$(EXESUF): tests/blockdev-test.o $(libqos-pc-obj-y) > tests/qemu-iotests/socket_scm_helper$(EXESUF): tests/qemu-iotests/sock= et_scm_helper.o > =20 > # QTest rules > diff --git a/tests/blockdev-test.c b/tests/blockdev-test.c > new file mode 100644 > index 0000000..8b7371e > --- /dev/null > +++ b/tests/blockdev-test.c [...] > +int main(int argc, char **argv) > +{ > + g_test_init(&argc, &argv, NULL); > + > + qtest_add_func("/qdev/drive_add_empty", test_drive_add_empty); I would prefer not to name that "qdev" if you can think of something better... otherwise test looks fine. Andreas > + > + return g_test_run(); > +} >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg