From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve8tk-0007AM-Cq for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:36:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve8tY-0003zr-Or for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:36:15 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:60160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve8tY-0003zn-JH for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:36:04 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Nov 2013 14:36:03 -0500 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 5F26D6E803C for ; Wed, 6 Nov 2013 14:35:59 -0500 (EST) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b01cxnp22036.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rA6Ja0ue6488474 for ; Wed, 6 Nov 2013 19:36:01 GMT Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rA6Ja0lD025398 for ; Wed, 6 Nov 2013 12:36:00 -0700 Message-ID: <527A9A1F.9090509@linux.vnet.ibm.com> Date: Wed, 06 Nov 2013 14:35:59 -0500 From: Corey Bryant MIME-Version: 1.0 References: <1383748741-8865-1-git-send-email-coreyb@linux.vnet.ibm.com> <527A6A9D.80009@redhat.com> In-Reply-To: <527A6A9D.80009@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: aliguori@amazon.com On 11/06/2013 11:13 AM, Eric Blake wrote: > On 11/06/2013 07:39 AM, Corey Bryant wrote: > > [your git settings are odd; your messages came across as individual > threads rather than in-reply to the cover letter] > I wonder if that's because I sent each patch separately with git send-email? Sometimes it hangs when I send more than 1. >> This patch provides HMP 'info tpm', QMP 'query-tpm' and QMP >> 'query-tpm-types' support for the libtpms TPM backend. >> >> Signed-off-by: Corey Bryant >> --- >> hmp.c | 5 +++++ >> include/sysemu/tpm_backend.h | 1 + >> qapi-schema.json | 18 ++++++++++++++++-- >> tpm.c | 7 +++++++ >> 4 files changed, 29 insertions(+), 2 deletions(-) >> >> +++ b/qapi-schema.json >> @@ -3673,10 +3673,11 @@ >> # An enumeration of TPM types >> # >> # @passthrough: TPM passthrough type >> +# @libtpms: TPM libtpms type > > Worth adding '(since 1.8)' to mark when this enum value was added. > >> # @TpmTypeOptions: >> # >> # A union referencing different TPM backend types' configuration options >> # >> # @passthrough: The configuration options for the TPM passthrough type >> +# @libtpms: The configuration options for the TPM libtpms type > > here as well. > >> # >> # Since: 1.5 >> ## >> { 'union': 'TpmTypeOptions', >> - 'data': { 'passthrough' : 'TPMPassthroughOptions' } } >> + 'data': { 'passthrough' : 'TPMPassthroughOptions', >> + 'libtpms' : 'TPMLibtpmsOptions' } } >> > > Otherwise it looks okay to me. > Thanks for the comments. I'll add them to the next version. Can I add your Reviewed-by to this patch? -- Regards, Corey Bryant