All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RFC: get_dma_buf_unless_zero ?
Date: Wed, 06 Nov 2013 20:59:03 +0100	[thread overview]
Message-ID: <527A9F87.2070400@vmware.com> (raw)

Anyone else but me that feels such a function could be useful?

My main use-case is that it would resolve the mutual refcounting problem:

1) drm buffer object caches a dma_buf pointer which it refcounts
2) The dma-buf holds a refcount to the buffer.

This is resolved today by having the user-space visible part of the 
drm-buffer holding the refcount to the dma_buf. When user-space closes 
the drm-buffer, the reference goes away, and eventually the buffer is 
freed, when all external dma-buf users are done with the dma-buf

However, this also means that the dma-buf remains for the buffer 
lifetime even when there are no external users, which bugs me a bit.

This can be resolved by viewing the drm buffer as a lookup structure 
that doesn't hold a refcount to the dma-buf, but that means that the 
lookup structure (buffer) would need to share locks with the dma-buf 
implementation, unless we have a get_dma_buf_unless_zero, which means we 
can use locks local to the lookup structure, the drm buffer.
(See the last part of the kref documentation for a detailed discussion 
of this).

Now I don't think keeping the dma_buf for the drm buffer lifetime is a 
HUGE problem, but I just wanted to get people's views of this.

Thanks,
Thomas

                 reply	other threads:[~2013-11-06 19:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527A9F87.2070400@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.