From: Eric Blake <eblake@redhat.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend
Date: Wed, 06 Nov 2013 13:15:54 -0700 [thread overview]
Message-ID: <527AA37A.7090801@redhat.com> (raw)
In-Reply-To: <527A9A1F.9090509@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On 11/06/2013 12:35 PM, Corey Bryant wrote:
>>> #
>>> # Since: 1.5
>>> ##
>>> { 'union': 'TpmTypeOptions',
>>> - 'data': { 'passthrough' : 'TPMPassthroughOptions' } }
>>> + 'data': { 'passthrough' : 'TPMPassthroughOptions',
>>> + 'libtpms' : 'TPMLibtpmsOptions' } }
>>>
>>
>> Otherwise it looks okay to me.
>>
>
> Thanks for the comments. I'll add them to the next version. Can I add
> your Reviewed-by to this patch?
Yes, now that I've looked at the full patch (and not just the .json):
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
prev parent reply other threads:[~2013-11-06 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 14:39 [Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend Corey Bryant
2013-11-06 16:13 ` Eric Blake
2013-11-06 19:35 ` Corey Bryant
2013-11-06 20:15 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527AA37A.7090801@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.