All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] ARM: OMAP5: Add Pipe3 PHY driver
Date: Wed, 6 Nov 2013 16:48:32 -0500	[thread overview]
Message-ID: <527AB930.40509@ti.com> (raw)
In-Reply-To: <1383749246-30895-3-git-send-email-rogerq@ti.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/06/2013 09:47 AM, Roger Quadros wrote:
> Pipe3 PHY is used by SATA, USB3 and PCIe modules. This is
> a driver for the Pipe3 PHY.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
[snip]
> +#define perror(fmt, args...) printf("%s: " fmt, __func__ , ##args)

Please use the debug macro.

[snip[
> +	perror("%s: No DPLL configuration for %u Hz SYS CLK\n",
> +							__func__, rate);

Indent is wrong, we do like the kernel (and checkpatch.pl is in tools/
and will catch these).  Thanks.

Code itself seems fine tho, thanks.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSerkvAAoJENk4IS6UOR1WoscQAJPuEI2msKOndDsaVdQcD8oQ
zy2H6hXl4o9FwZd9B6Q3xigjUcjJ9a/g8dBxEprB96pv+8s52R5QUfvP88kFrAJ7
Nq/Yb0EeHVNmsQoOAaFrmeYd6iJ+XFJv93G0bD1cSVTPoynnIl0kyeicN8rf2lNV
ZbU8qdxyYwxK3BaBMyh+jarCx+glXmDuQgcRMJ8t7KWOKKvOpiVzpksoZvoSucrN
gIKfxyPbvUSEFwx95oN0VfAvAhOzrnHF1ghp7CSnatVWuqGWpseqqIC0oosRe1ob
GFUOxWYK3jUIwE8KYgbcHl0Zie7jEWegYOlkOxurivRZS8AcOoi9IycJlTGGO/vX
REgdHSKm6O5NxHBW6X6rBrL44YuR0WnVKmBLVeGcGxqSfpgkXRG+6Pa8XBSmYDgU
k26tb2JXSkpUwMRu9omKn96nbaWAAo3IUnB/ErWuPjvhADRZcERYH1UdNnSY3BvW
PsgeUEL7j67/s9EHShwtPLBRN22CJVgefnV1oxBgK7I1IZkgiUS3EVN53Z/edFTw
XKR+sN8SRM9pAV4DzGVElK5njdoy11ez9Xc1cG7lenLJJv1MTCo1NVqG136NvldS
OURc8Hp0G92OBGUBts5gDDeJTgn1fEnfSizZZ9JJP8B2I7WXV41rzGvswHR12tgE
EP0V6CqWSWjeOoj9DFhS
=tTZq
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-11-06 21:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 14:47 [U-Boot] [RFC][PATCH 0/5] SATA support for OMAP5 uevm Roger Quadros
2013-11-06 14:47 ` [U-Boot] [PATCH 1/5] ahci: Error out with message on malloc() failure Roger Quadros
2013-11-06 14:47 ` [U-Boot] [PATCH 2/5] ARM: OMAP5: Add Pipe3 PHY driver Roger Quadros
2013-11-06 21:48   ` Tom Rini [this message]
2013-11-07 12:23     ` Roger Quadros
2013-11-11 13:52       ` Tom Rini
2013-11-11 13:57         ` Roger Quadros
2013-11-06 14:47 ` [U-Boot] [PATCH 3/5] ARM: OMAP5: Add PRCM and Control information for SATA Roger Quadros
2013-11-06 14:47 ` [U-Boot] [PATCH 4/5] ARM: OMAP5: Add SATA platform glue Roger Quadros
2013-11-06 22:11   ` Tom Rini
2013-11-07 12:24     ` Roger Quadros
2013-11-06 14:47 ` [U-Boot] [PATCH 5/5] ARM: omap5_uevm: Add SATA support Roger Quadros
2013-11-07  8:52 ` [U-Boot] [RFC][PATCH 0/5] SATA support for OMAP5 uevm Enric Balletbo Serra
2013-11-07 10:44   ` Roger Quadros
     [not found]     ` <509F47360D0ED54AA79C245CC4A9E6EA98F02D@DBDE04.ent.ti.com>
2013-11-11 13:16       ` Roger Quadros
     [not found]         ` <509F47360D0ED54AA79C245CC4A9E6EA98FDD1@DBDE04.ent.ti.com>
2014-01-08  7:29           ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527AB930.40509@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.