Re: [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On 11/06/2013 06:04 AM, Juan Quintela wrote:
> We don't need to make special things for CODE, just set the other two bits
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  exec.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 36b0a66..27e4540 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1374,12 +1374,8 @@ found:
>  static void notdirty_mem_write(void *opaque, hwaddr ram_addr,
>                                 uint64_t val, unsigned size)
>  {
> -
> -    int dirty_flags;

Huh, you just undid the whitespace addition I called out in 6/39.

For 7 and 8,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]