From: Huang Shijie <b32955@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: marex@denx.de, linux-mtd@lists.infradead.org,
computersforpeace@gmail.com, dwmw2@infradead.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 1/2] mtd: gpmi: Revert "mtd: gpmi: scan two nand chips"
Date: Thu, 7 Nov 2013 10:45:10 +0800 [thread overview]
Message-ID: <527AFEB6.20004@freescale.com> (raw)
In-Reply-To: <1383758172-29798-1-git-send-email-festevam@gmail.com>
于 2013年11月07日 01:16, Fabio Estevam 写道:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> This revert is needed so that the revert of commit f720e7ce5
> ("mtd: gpmi: remove the nand_scan()") can be succesfully applied.
>
> This reverts commit cdef39de399fc6806f85c60ef97c9e394b3a92d4.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 7ac2280..a5c60c4 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1674,7 +1674,7 @@ static int gpmi_nfc_init(struct gpmi_nand_data *this)
> if (ret)
> goto err_out;
>
> - ret = nand_scan_ident(mtd, 2, NULL);
> + ret = nand_scan_ident(mtd, 1, NULL);
> if (ret)
> goto err_out;
>
Please do not revert the patches.
It's not the right way to fix this.
I will spend some time to this bug today.
thanks
Huang Shijie
prev parent reply other threads:[~2013-11-07 2:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 17:16 [PATCH 1/2] mtd: gpmi: Revert "mtd: gpmi: scan two nand chips" Fabio Estevam
2013-11-06 17:16 ` [PATCH 2/2] mtd: gpmi: Revert "mtd: gpmi: remove the nand_scan()" Fabio Estevam
2013-11-06 18:08 ` Brian Norris
2013-11-06 18:42 ` Fabio Estevam
2013-11-06 18:58 ` Brian Norris
2013-11-06 19:08 ` Fabio Estevam
2013-11-06 19:31 ` Marek Vasut
2013-11-07 2:45 ` Huang Shijie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527AFEB6.20004@freescale.com \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.