From: Laurent GONZALEZ <br2@gezedo.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled
Date: Thu, 07 Nov 2013 07:36:21 +0100 [thread overview]
Message-ID: <527B34E5.8050600@gezedo.com> (raw)
In-Reply-To: <da65cfab-4ae4-4ee4-86c4-60e3e9ba3d60@email.android.com>
On 06/11/2013 20:56, Thomas De Schampheleire wrote:
> Laurent GONZALEZ <br2@gezedo.com> wrote:
>> For configurations using a toolchain that is preinstalled on
>> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
>> empty to avoid downloading any toolchain package.
>> The actual implementation has been proposed by Thomas Petazzoni.
>>
>> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
>> ---
>> toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
>> index 2722600..e2e9953 100644
>> --- a/toolchain/toolchain-external/toolchain-external.mk
>> +++ b/toolchain/toolchain-external/toolchain-external.mk
>> @@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>> TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>> endif
>>
>> +# In fact, we don't need to download the toolchain, since it is already
>> +# available on the system, so force the site and source to be empty so
>> +# that nothing will be downloaded/extracted.
>> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y)
>> +TOOLCHAIN_EXTERNAL_SITE =
>> +TOOLCHAIN_EXTERNAL_SOURCE =
>> +endif
>> +
>> TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
>>
>> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
>
> In the previous thread you said there was still a problem with v2...
> What was that problem? I tested v2 and seemed to work fine...
>
There were no other problem than the one you highlighted in my very first thread.
This v3 looks good, when everyone agrees it should be ready for integration.
next prev parent reply other threads:[~2013-11-07 6:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 19:19 [Buildroot] [PATCH v3 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
2013-11-06 19:56 ` Thomas De Schampheleire
2013-11-07 6:36 ` Laurent GONZALEZ [this message]
2013-11-07 7:57 ` Thomas Petazzoni
2013-11-07 8:27 ` Thomas De Schampheleire
2013-11-10 23:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B34E5.8050600@gezedo.com \
--to=br2@gezedo.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.