From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, Ren Mingxin <renmx@cn.fujitsu.com>,
Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>
Subject: Re: [PATCH 2/5] scsi: improved eh timeout handler
Date: Thu, 07 Nov 2013 07:42:49 +0100 [thread overview]
Message-ID: <527B3669.307@suse.de> (raw)
In-Reply-To: <20131106144713.GA26551@infradead.org>
On 11/06/2013 03:47 PM, Christoph Hellwig wrote:
> On Tue, Nov 05, 2013 at 11:19:27AM -0800, Mike Christie wrote:
>>> + scmd->eh_eflags |= SCSI_EH_ABORT_SCHEDULED;
>>> + SCSI_LOG_ERROR_RECOVERY(3,
>>> + scmd_printk(KERN_INFO, scmd,
>>> + "scmd %p abort scheduled\n", scmd));
>>> + schedule_delayed_work(&scmd->abort_work, HZ / 100);
>>> + return SUCCESS;
>>> +}
>>
>> Do we want to use our own workqueue_struct with WQ_MEM_RECLAIM set?
>
> That's probably required, I can think of all kinds of issues otherwise.
>
> Not in this patch series, but in the near future it might make sense
> to convert the whole EH thread to that workqueue.
>
And given the recent issues we had with RT scheduling I guess this
is the way to go.
_After_ this patchset gets in, that is ...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-07 6:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 7:05 [PATCHv10 0/5] New EH command timeout handler Hannes Reinecke
2013-11-05 7:05 ` [PATCH 1/5] scsi: Fix erratic device offline during EH Hannes Reinecke
2013-11-05 7:05 ` [PATCH 2/5] scsi: improved eh timeout handler Hannes Reinecke
2013-11-05 19:19 ` Mike Christie
2013-11-06 6:48 ` Hannes Reinecke
2013-11-06 17:23 ` Mike Christie
2013-11-07 6:45 ` Hannes Reinecke
2013-11-07 18:33 ` Douglas Gilbert
2013-11-08 15:54 ` Hannes Reinecke
2013-11-09 8:35 ` James Bottomley
2013-11-09 15:27 ` Hannes Reinecke
2013-11-06 14:47 ` Christoph Hellwig
2013-11-07 6:42 ` Hannes Reinecke [this message]
2013-11-05 7:05 ` [PATCH 3/5] scsi: Unlock accesses to eh_deadline Hannes Reinecke
2013-11-05 7:05 ` [PATCH 4/5] scsi: Set the minimum valid value of 'eh_deadline' as 0 Hannes Reinecke
2013-11-05 7:05 ` [PATCH 5/5] scsi: Update documentation Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2013-11-11 12:44 [PATCHv11 0/5] New EH command timeout handler Hannes Reinecke
2013-11-11 12:44 ` [PATCH 2/5] scsi: improved eh " Hannes Reinecke
2014-02-11 14:01 ` Christoph Hellwig
2014-02-11 14:29 ` Hannes Reinecke
2014-02-12 7:45 ` Christoph Hellwig
2014-02-12 7:49 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B3669.307@suse.de \
--to=hare@suse.de \
--cc=hch@infradead.org \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=renmx@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.