From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeK07-00072k-SS for qemu-devel@nongnu.org; Thu, 07 Nov 2013 02:27:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeK02-0000nY-1k for qemu-devel@nongnu.org; Thu, 07 Nov 2013 02:27:35 -0500 Message-ID: <527B40CE.8050706@siemens.com> Date: Thu, 07 Nov 2013 08:27:10 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1381164805-452-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <5277A0EA.8050608@siemens.com> <878ux1tvod.fsf@linux.vnet.ibm.com> In-Reply-To: <878ux1tvod.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" , agraf@suse.de, paulus@samba.org Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 2013-11-06 16:08, Aneesh Kumar K.V wrote: > Jan Kiszka writes: > >> On 2013-10-07 18:53, Aneesh Kumar K.V wrote: >>> From: "Aneesh Kumar K.V" >>> >>> Targets like ppc64 support different typed of KVM, one which use >>> hypervisor mode and the other which doesn't. Add a new machine >>> property kvm_type that helps in selecting the respective ones >>> We also add a new QEMUMachine callback get_vm_type that helps >>> in mapping the string representation of kvm type specified. >>> >>> Signed-off-by: Aneesh Kumar K.V >> >> ... >> >>> diff --git a/vl.c b/vl.c >>> index 4e709d5..7ecc581 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -427,7 +427,12 @@ static QemuOptsList qemu_machine_opts = { >>> .name = "usb", >>> .type = QEMU_OPT_BOOL, >>> .help = "Set on/off to enable/disable usb", >>> + },{ >>> + .name = "kvm_type", >>> + .type = QEMU_OPT_STRING, >>> + .help = "Set to kvm type to be used in create vm ioctl", >> >> This does not sound like an appropriate documentation for an enduser. >> > > Any other suggestion for that ? It is actually a string which will be > parsed by the machine opt callback, and the return value is used as the > argument to create vm ioctl. Maybe something like this: "Specifies the KVM virtualization mode (xxx, yyy, whatever)" No user is interesting in how this information gets transfered to the KVM core. That's an irrelavant implementation detail. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux