From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] udoo: Improve stability of DDR3 setting
Date: Thu, 07 Nov 2013 09:12:26 +0100 [thread overview]
Message-ID: <527B4B6A.2020109@denx.de> (raw)
In-Reply-To: <1383769842.3741.11.camel@localhost>
Hi Giuseppe,
On 06/11/2013 21:30, Giuseppe Pagano wrote:
> Move udoo configuration files to board/udoo/ folder.
> Align clock configuration and DDR3 calibration to Seco suggested value
> to increase system stability.
>
There are some basic issues with your patchset. First, patches are
corrupted by your editor and/or by your mailer and cannot be applied.
ERROR: DOS line endings
#222: FILE: board/udoo/ddr-setup.cfg:71:
+DATA 4, MX6_IOM_GRP_DDRMODE, 0x00020000^M$
ERROR: DOS line endings
#223: FILE: board/udoo/ddr-setup.cfg:72:
+/* disable ddr pullups */^M$
Do not use editor that add carriage return at the end of the line.
Instead of generating the patches with diff, use "git format-patch", and
then submit the patches to the mailing list with "git send-email". This avoi
Please take a look at the rules to submit patches :
http://www.denx.de/wiki/U-Boot/Patches
Do not fix multiple issues in the same patch if not strictly needed. The
commit message is misleading: you say you are moving the configuration
files, but they are not moved (they can't because they belong to
nitrogen) and new files are generated.
I do not understand what you mean with "Align clock configuration and
DDR3 calibration to Seco suggested value". Please explain: which values
are wrong, what you have fix with your patch.
There should be a good reason to copy files. Generally, we do not want
to have copies of the same files.
If you make change to a board, you should send your patches in CC to the
board maintainer, too (for udoo, Fabio: I put him in CC).
> Signed-off-by: Giuseppe Pagano <giuseppe.pagano@seco.com>
> Cc: sbabic at denx.de
>
> ...
>
> diff -uNr a/board/udoo/1066mhz_4x256mx16.cfg
> b/board/udoo/1066mhz_4x256mx16.cfg
> --- a/board/udoo/1066mhz_4x256mx16.cfg
> +++ b/board/udoo/1066mhz_4x256mx16.cfg
General issue for generating patches. please use git format-patch as I
explained befoe.
> @@ -0,0 +1,56 @@
> +/*
> + * Copyright (C) 2013 Boundary Devices
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +
> +DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036
> +DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040
> +
> +DATA 4, MX6_MMDC_P0_MDCFG0, 0x54597955
> +DATA 4, MX6_MMDC_P0_MDCFG1, 0xFF328F64
> +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB
> +
> +DATA 4, MX6_MMDC_P0_MDMISC, 0x00001740
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008000
> +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2
> +
> +DATA 4, MX6_MMDC_P0_MDOR, 0x00591023
> +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027
> +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000
> +
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033
> +
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x00048031
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x09408030
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040
> +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1380003
> +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1380003
> +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800
> +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00011117
> +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00011117
> +
> +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x43510360
> +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x0342033F
> +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x033F033F
> +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x03290266
> +
> +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x4B3E4141
> +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x47413B4A
> +DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x42404843
> +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x4C3F4C45
> +
> +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x00350035
> +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x001F001F
> +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00010001
> +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00010001
> +
> +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800
> +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800
> +
> +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576
> +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006
> +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000
> +
> diff -uNr a/board/udoo/clocks.cfg b/board/udoo/clocks.cfg
> --- a/board/udoo/clocks.cfg
> +++ b/board/udoo/clocks.cfg
> @@ -0,0 +1,32 @@
> +/*
> + * Copyright (C) 2013 Boundary Devices
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + *
> + * Device Configuration Data (DCD)
> + *
> + * Each entry must have the format:
> + * Addr-type Address Value
> + *
> + * where:
> + * Addr-type register length (1,2 or 4 bytes)
> + * Address absolute address of the register
> + * value value to be stored in the register
> + */
> +
> +/* set the default clock gate to save power */
> +DATA 4, CCM_CCGR0, 0x00C03F3F
> +DATA 4, CCM_CCGR1, 0x0030FC03
> +DATA 4, CCM_CCGR2, 0x0FFFC000
> +DATA 4, CCM_CCGR3, 0x3FF00000
> +DATA 4, CCM_CCGR4, 0x00FFF300
> +DATA 4, CCM_CCGR5, 0x0F0000C3
> +DATA 4, CCM_CCGR6, 0x000003FF
> +
> +/* enable AXI cache for VDOA/VPU/IPU */
> +DATA 4, MX6_IOMUXC_GPR4, 0xF00000FF
> +
> +/* set IPU AXI-id0 Qos=0xf(bypass) AXI-id1 Qos=0x7 */
> +DATA 4, MX6_IOMUXC_GPR6, 0x007F007F
> +DATA 4, MX6_IOMUXC_GPR7, 0x007F007F
> +
> diff -uNr a/board/udoo/ddr-setup.cfg b/board/udoo/ddr-setup.cfg
> --- a/board/udoo/ddr-setup.cfg
> +++ b/board/udoo/ddr-setup.cfg
> @@ -0,0 +1,87 @@
> +/*
> + * Copyright (C) 2013 Boundary Devices
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + *
> + * Device Configuration Data (DCD)
> + *
> + * Each entry must have the format:
> + * Addr-type Address Value
> + *
> + * where:
> + * Addr-type register length (1,2 or 4 bytes)
> + * Address absolute address of the register
> + * value value to be stored in the register
> + */
> +
> +/*
> + * DDR3 settings
> + * MX6Q ddr is limited to 1066 Mhz currently 1056 MHz(528 MHz
> clock),
> + * memory bus width: 64 bits x16/x32/x64
> + * MX6DL ddr is limited to 800 MHz(400 MHz clock)
> + * memory bus width: 64 bits x16/x32/x64
> + * MX6SOLO ddr is limited to 800 MHz(400 MHz clock)
> + * memory bus width: 32 bits x16/x32
> + */
> +DATA 4, MX6_IOM_DRAM_SDQS0, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS1, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS2, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS3, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS4, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS5, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS6, 0x00000030
> +DATA 4, MX6_IOM_DRAM_SDQS7, 0x00000030
> +
> +DATA 4, MX6_IOM_GRP_B0DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B1DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B2DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B3DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B4DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B5DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B6DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_B7DS, 0x00000030
> +DATA 4, MX6_IOM_GRP_ADDDS, 0x00000030
> +/* 40 Ohm drive strength for cs0/1,sdba2,cke0/1,sdwe */
> +DATA 4, MX6_IOM_GRP_CTLDS, 0x00000030
> +
> +DATA 4, MX6_IOM_DRAM_DQM0, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM1, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM2, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM3, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM4, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM5, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM6, 0x00020030
> +DATA 4, MX6_IOM_DRAM_DQM7, 0x00020030
> +
> +DATA 4, MX6_IOM_DRAM_CAS, 0x00020030
> +DATA 4, MX6_IOM_DRAM_RAS, 0x00020030
> +DATA 4, MX6_IOM_DRAM_SDCLK_0, 0x00020030
> +DATA 4, MX6_IOM_DRAM_SDCLK_1, 0x00020030
> +
> +DATA 4, MX6_IOM_DRAM_RESET, 0x00020030
> +DATA 4, MX6_IOM_DRAM_SDCKE0, 0x00003000
> +DATA 4, MX6_IOM_DRAM_SDCKE1, 0x00003000
> +
> +DATA 4, MX6_IOM_DRAM_SDODT0, 0x00003030
> +DATA 4, MX6_IOM_DRAM_SDODT1, 0x00003030
> +
> +/* (differential input) */
> +DATA 4, MX6_IOM_DDRMODE_CTL, 0x00020000
> +/* (differential input) */
> +DATA 4, MX6_IOM_GRP_DDRMODE, 0x00020000
> +/* disable ddr pullups */
> +DATA 4, MX6_IOM_GRP_DDRPKE, 0x00000000
> +DATA 4, MX6_IOM_DRAM_SDBA2, 0x00000000
> +/* 40 Ohm drive strength for cs0/1,sdba2,cke0/1,sdwe */
> +DATA 4, MX6_IOM_GRP_DDR_TYPE, 0x000C0000
> +
> +/* Read data DQ Byte0-3 delay */
> +DATA 4, MX6_MMDC_P0_MPRDDQBY0DL, 0x33333333
> +DATA 4, MX6_MMDC_P0_MPRDDQBY1DL, 0x33333333
> +DATA 4, MX6_MMDC_P0_MPRDDQBY2DL, 0x33333333
> +DATA 4, MX6_MMDC_P0_MPRDDQBY3DL, 0x33333333
> +DATA 4, MX6_MMDC_P1_MPRDDQBY0DL, 0x33333333
> +DATA 4, MX6_MMDC_P1_MPRDDQBY1DL, 0x33333333
> +DATA 4, MX6_MMDC_P1_MPRDDQBY2DL, 0x33333333
> +DATA 4, MX6_MMDC_P1_MPRDDQBY3DL, 0x33333333
> +
> diff -uNr a/board/udoo/udoo.cfg b/board/udoo/udoo.cfg
> --- a/board/udoo/udoo.cfg
> +++ b/board/udoo/udoo.cfg
> @@ -0,0 +1,29 @@
> +/*
> + * Copyright (C) 2013 Boundary Devices
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + *
> + * Refer doc/README.imximage for more details about how-to configure
> + * and create imximage boot image
> + *
> + * The syntax is taken as close as possible with the kwbimage
> + */
> +
> +/* image version */
> +IMAGE_VERSION 2
> +
> +/*
> + * Boot Device : one of
> + * spi, sd (the board has no nand neither onenand)
> + */
> +BOOT_FROM sd
> +
> +#define __ASSEMBLY__
> +#include <config.h>
> +#include "asm/arch/mx6-ddr.h"
> +#include "asm/arch/iomux.h"
> +#include "asm/arch/crm_regs.h"
> +
> +#include "ddr-setup.cfg"
> +#include "1066mhz_4x256mx16.cfg"
> +#include "clocks.cfg"
> diff -uNr a/boards.cfg b/boards.cfg
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -283,7 +283,7 @@
> Active arm armv7 mx5 genesi
> mx51_efikamx mx51_efikamx
> mx51_efikamx:MACH_TYPE=MACH_TYPE_MX51_EFIKAMX,IMX_CONFIG=board/genesi/mx51_efikamx/imximage_mx.cfg -
> Active arm armv7 mx5 genesi
> mx51_efikamx mx51_efikasb
> mx51_efikamx:MACH_TYPE=MACH_TYPE_MX51_EFIKASB,IMX_CONFIG=board/genesi/mx51_efikamx/imximage_sb.cfg -
> Active arm armv7 mx5 ttcontrol vision2
> vision2
> vision2:IMX_CONFIG=board/ttcontrol/vision2/imximage_hynix.cfg
> Stefano Babic <sbabic@denx.de>
> -Active arm armv7 mx6 - udoo
> udoo_quad
> udoo:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q.cfg,MX6Q,DDR_MB=1024 Fabio Estevam <fabio.este...@freescale.com>
> +Active arm armv7 mx6 - udoo
> udoo_quad
> udoo:IMX_CONFIG=board/udoo/udoo.cfg,MX6Q,DDR_MB=1024 Fabio Estevam
It seems something wrong happens here...
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-11-07 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:30 [U-Boot] [PATCH 0/4] udoo: Improve stability of DDR3 setting Giuseppe Pagano
2013-11-07 8:12 ` Stefano Babic [this message]
2013-11-07 10:41 ` Giuseppe Pagano
2013-11-07 11:02 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B4B6A.2020109@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.