From: David Henningsson <david.henningsson@canonical.com>
To: Alex Hung <alex.hung@canonical.com>, Takashi Iwai <tiwai@suse.de>
Cc: Hui Wang <hui.wang@canonical.com>,
alsa-devel@alsa-project.org, YK <yk@canonical.com>
Subject: Re: [RFC] ALSA: hda - check for mute/micmute LEDs on all Lenovo machines (Realtek)
Date: Thu, 07 Nov 2013 09:34:14 +0100 [thread overview]
Message-ID: <527B5086.7070106@canonical.com> (raw)
In-Reply-To: <CAJ=jquZ0iir2e59d+afdj91JBYe2MiXsrQdam1PrS4BfKOdBmw@mail.gmail.com>
On 11/07/2013 02:58 AM, Alex Hung wrote:
> @Takashi and David,
>
> DMI is a good way to check models, and we may not need to check the
> years as older Thinkpads with no mute led do not have "MMTS" and
> "SSMS" control methods in ACPI DSDT. Checking their existence before
> making the actual calls in thinkpad-acpi avoids this problems.
So, the only thing we want to avoid is to load the module if it should
not be loaded, and the symbol_request call will always load the module.
So we want to avoid calling symbol_request if it's not a hardware that
is supported by thinkpad-acpi (and I assume that means Ideapads).
Should we check the DMI information to distinguish between Thinkpads and
Ideapads (and potentially others), and what DMI string would be best to
look for?
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
next prev parent reply other threads:[~2013-11-07 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 13:21 [RFC] ALSA: hda - check for mute/micmute LEDs on all Lenovo machines (Realtek) David Henningsson
2013-11-06 17:27 ` Takashi Iwai
2013-11-06 17:42 ` Takashi Iwai
2013-11-07 1:58 ` Alex Hung
2013-11-07 8:34 ` David Henningsson [this message]
2013-11-07 2:38 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B5086.7070106@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alex.hung@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=tiwai@suse.de \
--cc=yk@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.