From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeLcE-00072e-51 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:11:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeLc9-0001Ss-89 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:11:02 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:59574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeLc9-0001Rz-0B for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:10:57 -0500 Message-ID: <527B5918.3030305@msgid.tls.msk.ru> Date: Thu, 07 Nov 2013 13:10:48 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <52737BBA.4060109@msgid.tls.msk.ru> <52790E15.1000006@suse.com> In-Reply-To: <52790E15.1000006@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v2, 4/4] qemu-char: add missing characters used in keymaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Krupa Cc: qemu-devel@nongnu.org, Anthony Liguori 05.11.2013 19:26, Jan Krupa wrote: > On 11/01/2013 11:00 AM, Michael Tokarev wrote: [] >> Except of one question. Where we add these entries? Should we maybe >> sort the table somehow, or introduce some more groups of chars? >> >> (I'm fine with applying this to qemu-trivial as-is). > > I agree with sorting those entries to groups. But I think this is not a > straightforward task without completely rewriting the current groups > which seems to be a bit chaotic. Maybe what would be a good inspiration > is this libxkbcommon header file (which was probably used as a base data > for the current vnc_keysym.h, too): > > http://cgit.freedesktop.org/xorg/lib/libxkbcommon/tree/xkbcommon/xkbcommon-keysyms.h > > We can convert it into vnc_keysym.h retaining the groups used in > libxkbcommon, there. If you agree I can prepare patch for review. After a brief discussion with Anthony I think there's no need to do that at this time, due to a possibility to sort this all (not just the entries, but whole kbd stuff) using entirely different way. But I still think it is worth to apply this series for 1.7. Anthony, can you comment please? Are you willing to accept new keyboard layout plus a few mods required for it and for other, existing, layouts to function, together with a possibility to use base unicode chars (Unnnn)? It all can go away in 1.8 or later when proper keyboard handling hopefully will be in place... Thanks, /mjt