From: Gernot Hillier <gernot.hillier@siemens.com>
To: xenomai@xenomai.org
Subject: [Xenomai] [Xenomai-forge] [PATCH] Silence unused_result warning from write()
Date: Thu, 07 Nov 2013 10:22:07 +0100 [thread overview]
Message-ID: <527B5BBF.2040301@siemens.com> (raw)
Some glibc versions mark write() with attribute warn_unused_result (found in
Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning,
especially when building with -Werror.
Signed-off-by: Gernot Hillier <gernot.hillier@siemens.com>
---
lib/cobalt/init.c | 4 +++-
testsuite/latency/latency.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/cobalt/init.c b/lib/cobalt/init.c
index 101a2bd..568f9d0 100644
--- a/lib/cobalt/init.c
+++ b/lib/cobalt/init.c
@@ -53,7 +53,9 @@ int __rtdm_fd_start = INT_MAX;
static void sigill_handler(int sig)
{
const char m[] = "no Xenomai support in kernel?\n";
- write(2, m, sizeof(m) - 1);
+ if (write(2, m, sizeof(m) - 1) < 1) {
+ /* Silence unused_result warning. No handling in error case, though. */
+ }
exit(EXIT_FAILURE);
}
diff --git a/testsuite/latency/latency.c b/testsuite/latency/latency.c
index 7c5099b..b9e1f00 100644
--- a/testsuite/latency/latency.c
+++ b/testsuite/latency/latency.c
@@ -507,7 +507,9 @@ static void sigdebug(int sig, siginfo_t *si, void *context)
case SIGDEBUG_WATCHDOG:
n = snprintf(buffer, sizeof(buffer), "%s\n",
reason_str[reason]);
- write(STDERR_FILENO, buffer, n);
+ if (write(STDERR_FILENO, buffer, n) < 1) {
+ /* Silence unused_result warning. No handling in error case, though. */
+ }
exit(EXIT_FAILURE);
}
--
1.8.1.2
--
Regards,
Gernot Hillier
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next reply other threads:[~2013-11-07 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 9:22 Gernot Hillier [this message]
2013-11-07 18:01 ` [Xenomai] [Xenomai-forge] [PATCH] Silence unused_result warning from write() Gilles Chanteperdrix
2013-11-08 5:55 ` Gernot Hillier
2013-11-08 17:23 ` Gilles Chanteperdrix
2013-11-08 18:18 ` Jan Kiszka
2013-11-11 8:36 ` dietmar.schindler
2013-11-11 10:00 ` Gernot Hillier
2014-01-14 12:28 ` [Xenomai] [Xenomai-forge] [PATCH v2] " Gernot Hillier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B5BBF.2040301@siemens.com \
--to=gernot.hillier@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.