From: Anand Jain <Anand.Jain@oracle.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: linux-btrfs@vger.kernel.org, jbacik@fusionio.com, zab@redhat.com,
dsterba@suse.cz
Subject: Re: [PATCH 1/3] btrfs-progs: mechanism to fetch fsinfo from btrfs-control v3
Date: Thu, 07 Nov 2013 19:21:42 +0800 [thread overview]
Message-ID: <527B77C6.1090803@oracle.com> (raw)
In-Reply-To: <527B65A2.3020703@giantdisaster.de>
On 11/07/2013 06:04 PM, Stefan Behrens wrote:
> On Thu, 7 Nov 2013 18:01:41 +0800, Anand Jain wrote:
>> + *out_fslist = malloc(sz);
>> + if (*out_fslist == NULL) {
>> + ret = -ENOMEM;
>> + goto out;
>> + }
>> + memcpy(*out_fslist, fslist, sz);
>> + ret = 0;
>> +out:
>> + free(fsargs_saved);
>> + close(fd);
>> + return 0;
>> +}
>
> return ret;
nice catch. Thanks.
Also fsargs_saved wasn't initialized along with one of early goto out.
I have fixed it as well in v4 which was sent out.
Thanks, Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-
next prev parent reply other threads:[~2013-11-07 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 10:01 [PATCH 1/3] btrfs-progs: mechanism to fetch fsinfo from btrfs-control v3 Anand Jain
2013-11-07 10:01 ` [PATCH 2/3] btrfs-progs: fs show should handle if subvol(s) mounted v3 Anand Jain
2013-11-07 10:01 ` [PATCH 3/3] btrfs-progs: lblkid wouldn't find non mapper path input v3 Anand Jain
2013-11-07 10:05 ` Anand Jain
2013-11-07 11:18 ` [PATCH 1/3] btrfs-progs: mechanism to fetch fsinfo from btrfs-control v4 Anand Jain
2013-11-07 10:04 ` [PATCH 1/3] btrfs-progs: mechanism to fetch fsinfo from btrfs-control v3 Stefan Behrens
2013-11-07 11:21 ` Anand Jain [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-04 3:45 [PATCH 1/4] btrfs-progs: make filesystem show by label work Anand Jain
2013-11-07 10:06 ` [PATCH 1/3] btrfs-progs: mechanism to fetch fsinfo from btrfs-control v3 Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B77C6.1090803@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.