From: George Cherian <george.cherian@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <balbi@ti.com>, <stern@rowland.harvard.edu>,
<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_mass_storage: call try_to_freeze only when its safe
Date: Thu, 7 Nov 2013 19:35:14 +0530 [thread overview]
Message-ID: <527B9E1A.7000002@ti.com> (raw)
In-Reply-To: <527B9A7F.8000006@linutronix.de>
On 11/7/2013 7:19 PM, Sebastian Andrzej Siewior wrote:
> On 11/07/2013 02:37 PM, George Cherian wrote:
>> Call try_to_freeze() in sleep_thread() only when its safe to sleep.
>> do_read() and do_write() calls sleep_thread with lock held.
>> Make sure these wont call try_to_freeze() by passing can_freeze flag
>> to sleep_thread.
> Thank you. This is was Alan asked for and I forgot.
>
> You could add
>
> |Calling try_to_freeze() with a lock hold was done since day one in
> |f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no
> |locks held at freeze time") lockdep complains about it.
>
> so we have an explanation why it is suddenly a bad thing.
okay will send v2 with commit log amend and your Acked-by
>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Sebastian
--
-George
prev parent reply other threads:[~2013-11-07 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 13:37 [PATCH] usb: gadget: f_mass_storage: call try_to_freeze only when its safe George Cherian
2013-11-07 13:49 ` Sebastian Andrzej Siewior
2013-11-07 14:05 ` George Cherian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B9E1A.7000002@ti.com \
--to=george.cherian@ti.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.