From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe006.messaging.microsoft.com [216.32.180.16]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 7EBECE01757 for ; Thu, 7 Nov 2013 12:27:01 -0800 (PST) Received: from mail175-va3-R.bigfish.com (10.7.14.251) by VA3EHSOBE005.bigfish.com (10.7.40.25) with Microsoft SMTP Server id 14.1.225.22; Thu, 7 Nov 2013 20:26:59 +0000 Received: from mail175-va3 (localhost [127.0.0.1]) by mail175-va3-R.bigfish.com (Postfix) with ESMTP id 7E3981C0236; Thu, 7 Nov 2013 20:26:59 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(z579ehz98dIc89bh936eI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz1de098h8275bh1de097hz2dh2a8h839h93fhd25he5bhf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h1765h18e1h190ch1946h19b4h19c3h1ad9h1b0ah1b2fh2222h224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1f5fh1fe8h1ff5h209eh1155h) Received: from mail175-va3 (localhost.localdomain [127.0.0.1]) by mail175-va3 (MessageSwitch) id 1383856017457677_24975; Thu, 7 Nov 2013 20:26:57 +0000 (UTC) Received: from VA3EHSMHS007.bigfish.com (unknown [10.7.14.231]) by mail175-va3.bigfish.com (Postfix) with ESMTP id 536FA340064; Thu, 7 Nov 2013 20:26:57 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS007.bigfish.com (10.7.99.17) with Microsoft SMTP Server (TLS) id 14.16.227.3; Thu, 7 Nov 2013 20:26:57 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-001.039d.mgd.msft.net (10.84.1.13) with Microsoft SMTP Server (TLS) id 14.3.158.2; Thu, 7 Nov 2013 20:26:56 +0000 Received: from [10.29.244.25] ([10.29.244.25]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id rA7KQsDg031162; Thu, 7 Nov 2013 13:26:55 -0700 Message-ID: <527BF646.5040009@freescale.com> Date: Thu, 7 Nov 2013 18:21:26 -0200 From: Daiane Angolini Organization: Freescale Semiconductor User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Otavio Salvador , meta-freescale Mailing List References: <1383852398-12695-1-git-send-email-otavio@ossystems.com.br> <1383852398-12695-2-git-send-email-otavio@ossystems.com.br> In-Reply-To: <1383852398-12695-2-git-send-email-otavio@ossystems.com.br> X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Subject: Re: [meta-fsl-arm][PATCH 2/3] gst-fsl-plugin: Fix checking for include headers in multiple paths X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2013 20:27:02 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 07-11-2013 17:26, Otavio Salvador wrote: > This fixes the support for proper detecting Freescale specific headers > in include/linux and include/uapu. include/uapi > > Without this patch I have the configure log with the same feature in > 'enabled' and 'disabled' state and it was impossible to proper > override CPPFLAGS. > > After this patch, building it against MX53 I get: > > Configure result: > Enabled features: > plugin: aac_dec > plugin: mp3_dec > plugin: vorbis_dec > plugin: amr_dec > plugin: mp3_enc > plugin: h264_dec > plugin: mpeg4_dec > plugin: mpeg2_dec > plugin: aiur > plugin: beep > plugin: v4lsink > plugin: isink > plugin: ipucsc > library: libipu > library: libX11 > Disabled features: > plugin: aacp_dec > plugin: wma10_dec > plugin: ac3_dec > plugin: wma8_enc > plugin: downmix > plugin: wmv9mp_dec > plugin: wmv78_dec > plugin: vpu_wrap > > and building it against MX6Q I get: > > Configure result: > Enabled features: > plugin: aac_dec > plugin: mp3_dec > plugin: vorbis_dec > plugin: amr_dec > plugin: mp3_enc > plugin: h264_dec > plugin: mpeg4_dec > plugin: mpeg2_dec > plugin: vpu_wrap > plugin: aiur > plugin: beep > plugin: v4lsink > plugin: isink > plugin: ipucsc > library: libipu > library: libX11 > Disabled features: > plugin: aacp_dec > plugin: wma10_dec > plugin: ac3_dec > plugin: wma8_enc > plugin: downmix > plugin: wmv9mp_dec > plugin: wmv78_dec > > Change-Id: Icdd40a1686212275b67baede34bb45eb41be3cf1 > Reported-by: J=C4=81nis =C4=8Coders > Signed-off-by: Otavio Salvador > --- > recipes-multimedia/gstreamer/gst-fsl-plugin.inc | 6 +-- > ...c-Fix-checking-for-include-headers-in-mul.patch | 63 +++++++++++++= +++++++++ > .../gstreamer/gst-fsl-plugin_3.0.9.bb | 3 +- > 3 files changed, 67 insertions(+), 5 deletions(-) > create mode 100644 recipes-multimedia/gstreamer/gst-fsl-plugin/config= ure.ac-Fix-checking-for-include-headers-in-mul.patch > > diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc b/recipes-= multimedia/gstreamer/gst-fsl-plugin.inc > index e179c76..5331887 100644 > --- a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc > +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc > @@ -26,10 +26,8 @@ PLATFORM_mx6sl =3D "MX6SL" > PLATFORM_mx28 =3D "MX28" > > # Todo add a mechanism to map posible build targets > -INCLUDE_DIR =3D "-I${STAGING_KERNEL_DIR}/include/uapi -I${STAGING_KERN= EL_DIR}/include" > -EXTRA_OEMAKE =3D "INCLUDES=3D"${INCLUDE_DIR}"" > -EXTRA_OECONF =3D "PLATFORM=3D${PLATFORM} --disable-valgrind --disable-= examples --disable-debug CROSS_ROOT=3D${PKG_CONFIG_SYSROOT_DIR}" Are you droping CROSS_ROOT because now the configure can detect header=20 files properly? > -CACHED_CONFIGUREVARS +=3D "CROSS_ROOT=3D${STAGING_DIR_TARGET}" > +EXTRA_OECONF =3D "PLATFORM=3D${PLATFORM} --disable-valgrind --disable-= examples --disable-debug \ > + CPPFLAGS=3D"-I${STAGING_KERNEL_DIR}/include/uapi -I${S= TAGING_KERNEL_DIR}/include"" > > PACKAGES +=3D "${PN}-libmfwsconf ${PN}-libgplaycore ${PN}-libgstfsl \ > ${PN}-libme ${PN}-libgstbufmeta ${PN}-libmfwba \ > diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-F= ix-checking-for-include-headers-in-mul.patch b/recipes-multimedia/gstream= er/gst-fsl-plugin/configure.ac-Fix-checking-for-include-headers-in-mul.pa= tch > new file mode 100644 > index 0000000..abe5aa9 > --- /dev/null > +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-chec= king-for-include-headers-in-mul.patch > @@ -0,0 +1,63 @@ > +From be38dc1816d4de1a1b463988763f50226eb8417f Mon Sep 17 00:00:00 2001 > +From: Otavio Salvador > +Date: Thu, 7 Nov 2013 10:50:51 -0200 > +Subject: [PATCH] configure.ac: Fix checking for include headers in mul= tiple > + paths > +Organization: O.S. Systems Software LTDA. > + > +This fixes the support for proper detecting Freescale specific headers > +in include/linux and include/uapu. > + > +Without this patch we have the configure log with the same feature in > +'enabled' and 'disabled' state and it was impossible to override the > +CPPFLAGS. > + > +Upstream-Status: Pending > + > +Signed-off-by: Otavio Salvador > +--- > + configure.ac | 19 ++++++++----------- > + 1 file changed, 8 insertions(+), 11 deletions(-) > + > +diff --git a/configure.ac b/configure.ac > +index d74ee0e..f11c76c 100755 > +--- a/configure.ac > ++++ b/configure.ac > +@@ -58,13 +58,9 @@ AC_DEFUN([CHECK_DISABLE_FEATURE], > + [use_[$1]=3D$enableval], > + [use_[$1]=3Dyes]) > + if test "$use_[$1]" =3D "yes"; then > +- SAVE_CPPFLAGS=3D"$CPPFLAGS" > +- CPPFLAGS=3D`$PKG_CONFIG --cflags libfslaudiocodec` > +- CPPFLAGS+=3D`$PKG_CONFIG --cflags libfslvideocodec` > +- CPPFLAGS+=3D`$PKG_CONFIG --cflags libfslparser` > +- CPPFLAGS+=3D`$PKG_CONFIG --cflags libfslvpuwrap` > +- AC_CHECK_HEADERS([$4], HAVE_[$3]=3Dyes, HAVE_[$3]=3Dno && bre= ak) > +- CPPFLAGS=3D"$SAVE_CPPFLAGS" > ++ for h in "$4"; do > ++ AC_CHECK_HEADERS([$h], HAVE_[$3]=3Dyes && break, HAVE_[$3= ]=3Dno) > ++ done > + if test "x$HAVE_[$3]" =3D "xyes"; then > + enabled_feature=3D"$enabled_feature\n\t\t[$5]" > + else > +@@ -283,12 +279,13 @@ CHECK_DISABLE_FEATURE(beep, [Disable beep audio = decoder], [BEEP], [fsl_unia.h], > + > + CHECK_DISABLE_FEATURE(v4lsink, [Disable fsl v4l sink], [V4L_SINK], [l= inux/videodev2.h], [plugin: v4lsink]) > + > ++# Allow headers to be inside include/uapi and include/linux > + saved_CFLAGS=3D"$CFLAGS" > + CFLAGS=3D"$CFLAGS $IPU_CFLAGS" > +-CHECK_DISABLE_FEATURE(isink, [Disable fsl ipu sink], [I_SINK], [linux= /mxcfb.h], [plugin: isink]) > +-CHECK_DISABLE_FEATURE(isink, [Disable fsl ipu sink], [I_SINK], [uapi/= mxcfb.h], [plugin: isink]) > +-CHECK_DISABLE_FEATURE(ipucsc, [Disable fsl ipu csc], [I_CSC], [linux/= mxcfb.h], [plugin: ipucsc]) > +-CHECK_DISABLE_FEATURE(ipucsc, [Disable fsl ipu csc], [I_CSC], [uapi/m= xcfb.h], [plugin: ipucsc]) > ++ > ++CHECK_DISABLE_FEATURE(isink, [Disable fsl ipu sink], [I_SINK], [linux= /mxcfb.h uapi/mxcfb.h], [plugin: isink]) > ++CHECK_DISABLE_FEATURE(ipucsc, [Disable fsl ipu csc], [I_CSC], [linux/= mxcfb.h uapi/mxcfb.h], [plugin: ipucsc]) > ++ > + CFLAGS=3D$saved_CFLAGS > + > + CHECK_DISABLE_FEATURE(ipulib, [Disable ipu lib], [IPU_LIB], [mxc_ipu_= hl_lib.h], [library: libipu]) > +-- > +1.8.4.rc3 > + > diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb b/rec= ipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb > index 52813a5..fc9b38f 100644 > --- a/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb > +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb > @@ -5,7 +5,8 @@ require gst-fsl-plugin.inc > > # FIXME: Inspecting the source code the content is in fact 3.0.9 > SRC_URI =3D "${FSL_MIRROR}/gst-fsl-plugins-3.10.9-1.0.0.tar.gz \ > - file://remove-GST_INFO-in-mfw_gst_utils.h.patch" > + file://remove-GST_INFO-in-mfw_gst_utils.h.patch \ > + file://configure.ac-Fix-checking-for-include-headers-in-mul= .patch" > > SRC_URI[md5sum] =3D "a338a5c25225c765ae5f44af82fe7413" > SRC_URI[sha256sum] =3D "e809daa0cd60381f05a79f34a53305a5ee53bfed22192= a1cda6d998acc84a6fd" > Very nice patch! Let's wait for Janis Coders test in his side ;) --=20 Daiane