Re: [PATCH] perf: Disable warnings as errors for kernels 3.1+

[Saul Wold <sgw@linux.intel.com>]

On 11/07/2013 10:36 AM, Konrad Scherer wrote:
> From: Konrad Scherer <Konrad.Scherer@windriver.com>
>
> Turns out the sed command has not been working as intended since
> kernel 3.1 due to the trailing space. Adding the WERROR=0 environment
> variable is the correct way to disable warnings as errors.
>
So, I recently saw this failure:

ERROR: Logfile of failure stored in: 
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/genericx86_64-poky-linux/perf/1.0-r8/temp/log.do_configure.12897
Log data follows:
| DEBUG: Executing python function sysroot_cleansstate
| DEBUG: Python function sysroot_cleansstate finished
| DEBUG: Executing shell function do_configure
| sed: can't read 
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/genericx86-64/usr/src/kernel/tools/perf/Makefile: 
No such file or directory
| WARNING: 
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/genericx86_64-poky-linux/perf/1.0-r8/temp/run.do_configure.12897:1 
exit 2 from
|   sed -i 's,-Werror ,,' 
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/genericx86-64/usr/src/kernel/tools/perf/Makefile
| ERROR: Function failed: do_configure (log file is located at 
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/genericx86_64-poky-linux/perf/1.0-r8/temp/log.do_configure.12897)
NOTE: recipe perf-1.0-r8: task do_configure: Failed
ERROR: Task 3469 
(/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/meta/recipes-kernel/perf/perf.bb, 
do_configure) failed with exit code '1'

I am not sure that your patch will completely address this failure.

Sau!


> Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
> ---
>   meta/recipes-kernel/perf/perf.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 903ffa6..6258cbb 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -41,6 +41,9 @@ export STAGING_LIBDIR
>   export BUILD_SYS
>   export HOST_SYS
>
> +#kernel 3.1+ supports WERROR to disable warnings as errors
> +export WERROR = "0"
> +
>   do_populate_lic[depends] += "virtual/kernel:do_populate_sysroot"
>
>   # needed for building the tools/perf Perl binding
> @@ -115,6 +118,7 @@ do_install() {
>   }
>
>   do_configure_prepend () {
> +    #kernels before 3.1 do not support WERROR env variable
>       sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
>   }
>
>