From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v2 03/12] xenctx: Output ascii version of stack also. Date: Thu, 7 Nov 2013 19:12:13 -0500 Message-ID: <527C2C5D.5010008@terremark.com> References: <1383768500-4245-1-git-send-email-dslutz@terremark.com> <1383768500-4245-4-git-send-email-dslutz@terremark.com> <527B58E60200007800100787@nat28.tlf.novell.com> <1383828194.32399.25.camel@kazak.uk.xensource.com> <527BA0EF0200007800100A78@nat28.tlf.novell.com> <527BA1D80200007800100A9D@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VeZm4-0004FU-Jd for xen-devel@lists.xenproject.org; Fri, 08 Nov 2013 00:18:08 +0000 In-Reply-To: <527BA1D80200007800100A9D@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Ian Campbell Cc: Stefano Stabellini , GeorgeDunlap , Don Slutz , Ian Jackson , Don Slutz , xen-devel List-Id: xen-devel@lists.xenproject.org On 11/07/13 08:21, Jan Beulich wrote: >>>> On 07.11.13 at 14:17, "Jan Beulich" wrote: >>>>> On 07.11.13 at 13:43, Ian Campbell wrote: >>> On Thu, 2013-11-07 at 08:09 +0000, Jan Beulich wrote: >>>>>>> On 06.11.13 at 21:08, Don Slutz wrote: >>>> Why? I personally don't see a need - there's rarely much useful >>>> ASCII data on the stack. >>> This is true IME >>> >>>> So afaic: If at all, then only via command >>>> line option defaulting to off. >>> Well, assuming it doesn't make the output >80 columns (which I can't >>> tell from here) it seems harmless enough? >> If you end up looking at the output in a wide enough window, it'll >> make you scroll more. > Oops, I was mentally in patch 04 here. So yes, it may be harmless, > but clutters the data that you need to look at, and I personally > prefer to look at _just_ the data that's interesting, without having > to (mentally or physically) discard other pieces. > > Jan > I am happy to make it a command line option. -Don Slutz