From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v2 04/12] xenctx: Add stack address to dump,
 switch to 16 bytes per line.
Date: Thu, 7 Nov 2013 19:13:37 -0500
Message-ID: <527C2CB1.2030508@terremark.com>
References: <1383768500-4245-1-git-send-email-dslutz@terremark.com>	
	<1383768500-4245-5-git-send-email-dslutz@terremark.com>	
	<527B598C0200007800100793@nat28.tlf.novell.com>
	<1383828377.32399.28.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dslutz@verizon.com>) id 1VeZmN-0004P8-5a
	for xen-devel@lists.xenproject.org; Fri, 08 Nov 2013 00:18:27 +0000
In-Reply-To: <1383828377.32399.28.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Don Slutz <Don@CloudSwitch.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 11/07/13 07:46, Ian Campbell wrote:
> On Thu, 2013-11-07 at 08:12 +0000, Jan Beulich wrote:
>>>>> On 06.11.13 at 21:08, Don Slutz <dslutz@verizon.com> wrote:
>> Again - why?
> Having the stack address there can make it easier to locate a word
> referenced by a register for example, without error prone counting. In
> general many of the changelogs in this series could do with a second
> sentence in them after the title giving some rationale so we don't have
> to guess.
>
>>   This makes it just two entries per line for a 64-bit
>> guest. Pretty little I would say.
> Agreed.
>
> I expect that along with the previous patch lines would now be over 80
> columns for sure. If that's the case then either the ascii or the
> address (or both) needs to be optional IMHO.
>
>> Jan
>>
I am happy to make it a command line option.
    -Don Slutz