All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Update description for	NewImageMode
Date: Fri, 08 Nov 2013 10:48:04 +0800	[thread overview]
Message-ID: <527C50E4.1050402@linux.vnet.ibm.com> (raw)
In-Reply-To: <1383850068-3903-1-git-send-email-mreitz@redhat.com>

于 2013/11/8 2:47, Max Reitz 写道:
> If the NewImageMode is "absolute-paths" but no backing file is available
> (e.g., when mirroring a device with an unbacked image), the target image
> will not be backed either. This patch updates the documentation in
> qapi-schema.json accordingly.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Follow-up to:
>   - block/drive-mirror: Check for NULL backing_hd
> ---
>   qapi-schema.json | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 81a375b..dde8e45 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1736,7 +1736,8 @@
>   # @existing: QEMU should look for an existing image file.
>   #
>   # @absolute-paths: QEMU should create a new image with absolute paths
> -# for the backing file.
> +# for the backing file. If there is no backing file available, the new
> +# image will not be backed either.
>   #
>   # Since: 1.1
>   ##
> 
  It seems 2nd line should start with space, how about:
# @absolute-paths: QEMU should create a new image with absolute paths,
#                  the new image would usually have a backing file. If
#                  no backing file available, the new image will not be
#                  backed either.

  parent reply	other threads:[~2013-11-08  2:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 18:47 [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode Max Reitz
2013-11-07 18:52 ` Benoît Canet
2013-11-07 20:01 ` Eric Blake
2013-11-08  2:48 ` Wenchao Xia [this message]
2013-11-11 16:01 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527C50E4.1050402@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.