From: Yasuaki Ishimatsu <isimatu.yasuaki-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org,
richard-/L3Ra7n9ekc@public.gmane.org,
jlee-IBi9RG/b67k@public.gmane.org
Subject: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia
Date: Fri, 8 Nov 2013 16:33:09 +0900 [thread overview]
Message-ID: <527C93B5.7010407@jp.fujitsu.com> (raw)
By following works, my system very often fails set_variable() to set new
variable to efi variable storage and shows "efivars: set_variable() failed:
status=-28" message.
- commit 31ff2f20d9003e74991d135f56e503fe776c127c
efi: Distinguish between "remaining space" and actually used space
- commit 8c58bf3eec3b8fc8162fe557e9361891c20758f2
x86,efi: Implement efi_no_storage_paranoia parameter
- commit f8b8404337de4e2466e2e1139ea68b1f8295974f
Modify UEFI anti-bricking code
When booting my system, remaining space of efi variable storage is about
5KB. So there is no room that sets a new variable to the storage.
According to above works, efi_no_storage_paranoia parameter was prepared
for sane UEFI which can do gc and fulfills spec. But why need a system
with a sane UEFI set the parameter? It is wrong. A system with a broken
UEFI should set the parameter.
This patch changes name of the parameter to efi_storage_paranoia and uses
all efi variable storage with no parameter.
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
CC: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
CC: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
CC: Lee, Chun-Y <jlee-IBi9RG/b67k@public.gmane.org>
CC: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
Documentation/kernel-parameters.txt | 10 +++++-----
arch/x86/platform/efi/efi.c | 8 ++++----
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index fcbb736..2157c8e 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -888,11 +888,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
edd= [EDD]
Format: {"off" | "on" | "skip[mbr]"}
- efi_no_storage_paranoia [EFI; X86]
- Using this parameter you can use more than 50% of
- your efi variable storage. Use this parameter only if
- you are really sure that your UEFI does sane gc and
- fulfills the spec otherwise your board may brick.
+ efi_storage_paranoia [EFI; X86]
+ Using this parameter you cannot use your efi variable
+ storage when the remaining space of the storage becomes
+ less than 5KB. Use this parameter if your UEFI does
+ not sane gc and fulfills the spec.
eisa_irq_edge= [PARISC,HW]
See header of drivers/parisc/eisa.c.
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index c7e22ab..010a0eb 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -107,14 +107,14 @@ static int __init setup_add_efi_memmap(char *arg)
}
early_param("add_efi_memmap", setup_add_efi_memmap);
-static bool efi_no_storage_paranoia;
+static bool efi_storage_paranoia;
static int __init setup_storage_paranoia(char *arg)
{
- efi_no_storage_paranoia = true;
+ efi_storage_paranoia = true;
return 0;
}
-early_param("efi_no_storage_paranoia", setup_storage_paranoia);
+early_param("efi_storage_paranoia", setup_storage_paranoia);
static efi_status_t virt_efi_get_time(efi_time_t *tm, efi_time_cap_t *tc)
@@ -1066,7 +1066,7 @@ efi_status_t efi_query_variable_store(u32 attributes, unsigned long size)
* 5KB. This figure was provided by Samsung, so should be safe.
*/
if ((remaining_size - size < EFI_MIN_RESERVE) &&
- !efi_no_storage_paranoia) {
+ efi_storage_paranoia) {
/*
* Triggering garbage collection may require that the firmware
WARNING: multiple messages have this Message-ID (diff)
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: <linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <matt.fleming@intel.com>, <matthew.garrett@nebula.com>,
<richard@nod.at>, <jlee@suse.com>
Subject: [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia
Date: Fri, 8 Nov 2013 16:33:09 +0900 [thread overview]
Message-ID: <527C93B5.7010407@jp.fujitsu.com> (raw)
By following works, my system very often fails set_variable() to set new
variable to efi variable storage and shows "efivars: set_variable() failed:
status=-28" message.
- commit 31ff2f20d9003e74991d135f56e503fe776c127c
efi: Distinguish between "remaining space" and actually used space
- commit 8c58bf3eec3b8fc8162fe557e9361891c20758f2
x86,efi: Implement efi_no_storage_paranoia parameter
- commit f8b8404337de4e2466e2e1139ea68b1f8295974f
Modify UEFI anti-bricking code
When booting my system, remaining space of efi variable storage is about
5KB. So there is no room that sets a new variable to the storage.
According to above works, efi_no_storage_paranoia parameter was prepared
for sane UEFI which can do gc and fulfills spec. But why need a system
with a sane UEFI set the parameter? It is wrong. A system with a broken
UEFI should set the parameter.
This patch changes name of the parameter to efi_storage_paranoia and uses
all efi variable storage with no parameter.
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
CC: Matthew Garrett <matthew.garrett@nebula.com>
CC: Richard Weinberger <richard@nod.at>
CC: Lee, Chun-Y <jlee@suse.com>
CC: Matt Fleming <matt.fleming@intel.com>
---
Documentation/kernel-parameters.txt | 10 +++++-----
arch/x86/platform/efi/efi.c | 8 ++++----
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index fcbb736..2157c8e 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -888,11 +888,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
edd= [EDD]
Format: {"off" | "on" | "skip[mbr]"}
- efi_no_storage_paranoia [EFI; X86]
- Using this parameter you can use more than 50% of
- your efi variable storage. Use this parameter only if
- you are really sure that your UEFI does sane gc and
- fulfills the spec otherwise your board may brick.
+ efi_storage_paranoia [EFI; X86]
+ Using this parameter you cannot use your efi variable
+ storage when the remaining space of the storage becomes
+ less than 5KB. Use this parameter if your UEFI does
+ not sane gc and fulfills the spec.
eisa_irq_edge= [PARISC,HW]
See header of drivers/parisc/eisa.c.
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index c7e22ab..010a0eb 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -107,14 +107,14 @@ static int __init setup_add_efi_memmap(char *arg)
}
early_param("add_efi_memmap", setup_add_efi_memmap);
-static bool efi_no_storage_paranoia;
+static bool efi_storage_paranoia;
static int __init setup_storage_paranoia(char *arg)
{
- efi_no_storage_paranoia = true;
+ efi_storage_paranoia = true;
return 0;
}
-early_param("efi_no_storage_paranoia", setup_storage_paranoia);
+early_param("efi_storage_paranoia", setup_storage_paranoia);
static efi_status_t virt_efi_get_time(efi_time_t *tm, efi_time_cap_t *tc)
@@ -1066,7 +1066,7 @@ efi_status_t efi_query_variable_store(u32 attributes, unsigned long size)
* 5KB. This figure was provided by Samsung, so should be safe.
*/
if ((remaining_size - size < EFI_MIN_RESERVE) &&
- !efi_no_storage_paranoia) {
+ efi_storage_paranoia) {
/*
* Triggering garbage collection may require that the firmware
next reply other threads:[~2013-11-08 7:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 7:33 Yasuaki Ishimatsu [this message]
2013-11-08 7:33 ` [PATCH] x86, efi: change name of efi_no_storage_paranoia parameter to efi_storage_paranoia Yasuaki Ishimatsu
[not found] ` <527C93B5.7010407-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-11-08 8:05 ` Richard Weinberger
2013-11-08 8:05 ` Richard Weinberger
[not found] ` <527C9B5C.6040509-/L3Ra7n9ekc@public.gmane.org>
2013-11-08 8:46 ` Madper Xie
2013-11-08 8:46 ` Madper Xie
2013-11-08 9:34 ` Yasuaki Ishimatsu
2013-11-08 9:34 ` Yasuaki Ishimatsu
2013-11-08 9:37 ` Richard Weinberger
[not found] ` <527CB0F4.8080606-/L3Ra7n9ekc@public.gmane.org>
2013-11-08 10:25 ` Yasuaki Ishimatsu
2013-11-08 10:25 ` Yasuaki Ishimatsu
2013-11-08 10:29 ` Richard Weinberger
[not found] ` <527CBD01.1000908-/L3Ra7n9ekc@public.gmane.org>
2013-11-08 10:32 ` Yasuaki Ishimatsu
2013-11-08 10:32 ` Yasuaki Ishimatsu
[not found] ` <527CBDD3.2020609-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-11-08 14:34 ` Matt Fleming
2013-11-08 14:34 ` Matt Fleming
[not found] ` <20131108143421.GB22636-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-11 8:52 ` Yasuaki Ishimatsu
2013-11-11 8:52 ` Yasuaki Ishimatsu
[not found] ` <52809AEB.9080100-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-11-11 9:47 ` Madper Xie
2013-11-11 9:47 ` Madper Xie
2013-11-11 10:54 ` Matt Fleming
2013-11-11 10:54 ` Matt Fleming
[not found] ` <20131111105424.GD22636-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-19 3:03 ` Yasuaki Ishimatsu
2013-11-19 3:03 ` Yasuaki Ishimatsu
[not found] ` <528AD50D.6060503-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-11-19 3:16 ` Madper Xie
2013-11-19 3:16 ` Madper Xie
[not found] ` <87siutqdwv.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-20 6:26 ` Yasuaki Ishimatsu
2013-11-20 6:26 ` Yasuaki Ishimatsu
[not found] ` <528C562B.3070008-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-11-20 8:08 ` joeyli
2013-11-20 8:08 ` joeyli
2013-11-21 9:13 ` Yasuaki Ishimatsu
2013-11-21 9:13 ` Yasuaki Ishimatsu
[not found] ` <528DCED7.5070806-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-11-21 9:53 ` joeyli
2013-11-21 9:53 ` joeyli
[not found] ` <1385027623.6516.4090.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-11-21 10:27 ` joeyli
2013-11-21 10:27 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527C93B5.7010407@jp.fujitsu.com \
--to=isimatu.yasuaki-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=jlee-IBi9RG/b67k@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
--cc=richard-/L3Ra7n9ekc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.