From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4C009E01830 for ; Fri, 8 Nov 2013 00:40:36 -0800 (PST) Received: by mail-lb0-f181.google.com with SMTP id x18so1177824lbi.26 for ; Fri, 08 Nov 2013 00:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=MwxnV3BpZ8vhVFi8/8+a60HwG30ZOp/VGQ+GGmUQfpY=; b=CipuXXzlSBUtY+YHdMl291dj3kQe0EmTt1V22Bu6YPJxtVae4v72uWN1xcOxN1PUDG SiMWe0QxGsSIW/ZVPor+tQzPzUtCxc0STDWXPIhYyMQEOdUjxM5pg5rim5sWfG0nC2jE HWqjPBDfX+VAA97jA8bjXiIZbH5uFJqrSs1rd67stgqNfIivFSKv1Td+ipeegfKv/EjS ZtL9ZLj4zWqharzvvRwNbzPiHirixpaiYXlYkwd63WmxKfAZr3RYfVorMIIi6kjXuxGf krJRUs6an04FvcPuKRAVmex3Xpietnfnk+0M97AqVzaV67gRWC0MMGodMeuFBgvhGSSh aVZw== X-Received: by 10.152.239.164 with SMTP id vt4mr9812420lac.8.1383900035093; Fri, 08 Nov 2013 00:40:35 -0800 (PST) Received: from [10.0.1.5] ([80.232.254.7]) by mx.google.com with ESMTPSA id vx8sm5704335lbb.8.2013.11.08.00.40.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Nov 2013 00:40:33 -0800 (PST) Message-ID: <527CA383.8010406@gmail.com> Date: Fri, 08 Nov 2013 10:40:35 +0200 From: Janis Coders User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Otavio Salvador References: <1383852398-12695-1-git-send-email-otavio@ossystems.com.br> <1383852398-12695-2-git-send-email-otavio@ossystems.com.br> <527BF646.5040009@freescale.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH 2/3] gst-fsl-plugin: Fix checking for include headers in multiple paths X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2013 08:40:41 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Checked out dora-next branch and everything compiled fine for my custom board, which is based on imx53qsb. ipu_csc plugin is included and works as expected. Thank you. :) How/when dora-next branch is merged into dora? On 11/07/2013 10:43 PM, Otavio Salvador wrote: > Hello Daiane, > > On Thu, Nov 7, 2013 at 6:21 PM, Daiane Angolini > wrote: >> On 07-11-2013 17:26, Otavio Salvador wrote: >>> This fixes the support for proper detecting Freescale specific headers >>> in include/linux and include/uapu. >> >> include/uapi > Fixed in my tree. > >>> Without this patch I have the configure log with the same feature in >>> 'enabled' and 'disabled' state and it was impossible to proper >>> override CPPFLAGS. >>> >>> After this patch, building it against MX53 I get: >>> >>> Configure result: >>> Enabled features: >>> plugin: aac_dec >>> plugin: mp3_dec >>> plugin: vorbis_dec >>> plugin: amr_dec >>> plugin: mp3_enc >>> plugin: h264_dec >>> plugin: mpeg4_dec >>> plugin: mpeg2_dec >>> plugin: aiur >>> plugin: beep >>> plugin: v4lsink >>> plugin: isink >>> plugin: ipucsc >>> library: libipu >>> library: libX11 >>> Disabled features: >>> plugin: aacp_dec >>> plugin: wma10_dec >>> plugin: ac3_dec >>> plugin: wma8_enc >>> plugin: downmix >>> plugin: wmv9mp_dec >>> plugin: wmv78_dec >>> plugin: vpu_wrap >>> >>> and building it against MX6Q I get: >>> >>> Configure result: >>> Enabled features: >>> plugin: aac_dec >>> plugin: mp3_dec >>> plugin: vorbis_dec >>> plugin: amr_dec >>> plugin: mp3_enc >>> plugin: h264_dec >>> plugin: mpeg4_dec >>> plugin: mpeg2_dec >>> plugin: vpu_wrap >>> plugin: aiur >>> plugin: beep >>> plugin: v4lsink >>> plugin: isink >>> plugin: ipucsc >>> library: libipu >>> library: libX11 >>> Disabled features: >>> plugin: aacp_dec >>> plugin: wma10_dec >>> plugin: ac3_dec >>> plugin: wma8_enc >>> plugin: downmix >>> plugin: wmv9mp_dec >>> plugin: wmv78_dec >>> >>> Change-Id: Icdd40a1686212275b67baede34bb45eb41be3cf1 >>> Reported-by: Jānis Čoders >>> Signed-off-by: Otavio Salvador >>> --- >>> recipes-multimedia/gstreamer/gst-fsl-plugin.inc | 6 +-- >>> ...c-Fix-checking-for-include-headers-in-mul.patch | 63 >>> ++++++++++++++++++++++ >>> .../gstreamer/gst-fsl-plugin_3.0.9.bb | 3 +- >>> 3 files changed, 67 insertions(+), 5 deletions(-) >>> create mode 100644 >>> recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-checking-for-include-headers-in-mul.patch >>> >>> diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc >>> b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc >>> index e179c76..5331887 100644 >>> --- a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc >>> +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc >>> @@ -26,10 +26,8 @@ PLATFORM_mx6sl = "MX6SL" >>> PLATFORM_mx28 = "MX28" >>> >>> # Todo add a mechanism to map posible build targets >>> -INCLUDE_DIR = "-I${STAGING_KERNEL_DIR}/include/uapi >>> -I${STAGING_KERNEL_DIR}/include" >>> -EXTRA_OEMAKE = "INCLUDES="${INCLUDE_DIR}"" >>> -EXTRA_OECONF = "PLATFORM=${PLATFORM} --disable-valgrind >>> --disable-examples --disable-debug CROSS_ROOT=${PKG_CONFIG_SYSROOT_DIR}" >> >> Are you droping CROSS_ROOT because now the configure can detect header files >> properly? > ... > > It worked well without it and the code just uses it if it cannot find > the header. So in the new code it is unused. > > Quoted the configure.ac code below: > ... > AC_CHECK_HEADERS([linux/ipu.h], [HAVE_IPU_HEAD=yes], [HAVE_IPU_HEAD=no]) > AC_CHECK_HEADERS([ipu.h], [HAVE_IPU_HEAD=yes], [HAVE_IPU_HEAD=no]) > if test "x$HAVE_IPU_HEAD" = "xno"; then > ipuhead=`find $CROSS_ROOT/usr/src/ -name ipu.h | grep > "/linux/ipu.h" | head -n 1 | sed -e 's,/linux/ipu.h,,'` > if test "x$ipuhead" != "x"; then > IPU_CFLAGS=-I$ipuhead > fi > fi > ... > > This try to find the linux/ipu.h in standard paths (which is set in > sysroot option of gcc) and also the paths we provide in CPPFLAGS so it > is found properly and never runs it. > >> Very nice patch! Let's wait for Janis Coders test in his side ;) > I hope it works for him. I am also putting this in build in my > autobuilder for /all/ boards so we find out if it breaks something :) > > I am sure there're some other corner cases hidden in this code but > this simplifies the code and make it easier to spot it. > > Regards, >