From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 00/12] xenctx: Many changes. Date: Fri, 8 Nov 2013 11:29:32 +0000 Message-ID: <527CCB1C.4070800@eu.citrix.com> References: <1383768500-4245-1-git-send-email-dslutz@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383768500-4245-1-git-send-email-dslutz@terremark.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz , xen-devel@lists.xen.org, Ian Jackson , Stefano Stabellini , Ian Campbell , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 06/11/13 20:08, Don Slutz wrote: > From: Don Slutz > > Change from v1 to v2: > title was: xenctx: Add an option to output more registers. > Processed review comments. > Jan Beulich: > Split 1 change into 12. > Switch to enum for is_kernel_text(), renamed to is_kernel_addr(). > Renamed vars like memAddr to mem_addr. > Ian Campbell: > More on is_kernel_text(). I don't think this series really needs my Ack -- xenctx is actually in the wrong place, AFAICT, as it doesn't have anything really to do with xentrace. Its functionality is more similar to xen-hvmctx, which ATM lives in tools/misc. At some point it might make sense to reorg stuff a bit... -George