From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Subject: Re: [Linaro-mm-sig] thoughts of looking at android fences
Date: Fri, 08 Nov 2013 12:43:00 +0100
Message-ID: <527CCE44.7080009@canonical.com>
References: <524BCCD0.90002@canonical.com>	<CACSP8ShRk_m6VOvooaQ+T3aq=zf=LFz=u5rSF0mWXLfj6K+hQw@mail.gmail.com>	<CALAqxLUWLCQ67NHvpBoQUjP+s32YHh326uUgMH9Av5+Ma8stcg@mail.gmail.com>	<52556ABE.2090201@canonical.com>	<52690EEC.5000501@canonical.com>	<5270F8D7.4040406@canonical.com>	<CAMbhsRQ67B+MLLp-YhYhegDrOWp9AYN8eAaZnjdTc-wuwnM9vA@mail.gmail.com>	<5277777E.5060904@canonical.com>
	<CAABpnA-85QdwoYO5Ldz52bxw1_dWaQz541MjgEGZhwdu+Bhtvw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from youngberry.canonical.com (youngberry.canonical.com
	[91.189.89.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id C74C711352E
	for <dri-devel@lists.freedesktop.org>;
	Fri,  8 Nov 2013 03:43:03 -0800 (PST)
In-Reply-To: <CAABpnA-85QdwoYO5Ldz52bxw1_dWaQz541MjgEGZhwdu+Bhtvw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Rom Lemarchand <romlem@google.com>
Cc: "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>, Android Kernel Team <kernel-team@android.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Colin Cross <ccross@google.com>
List-Id: dri-devel@lists.freedesktop.org

op 07-11-13 22:11, Rom Lemarchand schreef:
> Hi Maarten, I tested your changes and needed the attached patch: behavior
> now seems equivalent as android sync. I haven't tested performance.
>
> The issue resolved by this patch happens when i_b < b->num_fences and i_a
>> = a->num_fences (or vice versa). Then, pt_a is invalid and so
> dereferencing pt_a->context causes a crash.
>
Yeah, I pushed my original fix. I intended to keep android userspace behavior the same, and I tried to keep the kernelspace the api same as much as I could. If peformance is the same, or not noticeably worse, would there be any objections on the android side about renaming dma-fence to syncpoint, and getting it in mainline?

~Maarten