From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vem3j-0004Uj-Ub for qemu-devel@nongnu.org; Fri, 08 Nov 2013 08:25:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vem3Z-0004Sw-Ro for qemu-devel@nongnu.org; Fri, 08 Nov 2013 08:25:11 -0500 Message-ID: <527CE62A.500@suse.de> Date: Fri, 08 Nov 2013 14:24:58 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <527B9D3B.3060407@suse.de> <1383898963-4772-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1383898963-4772-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] spapr: add "compat" machine option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Igor Mammedov , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini Am 08.11.2013 09:22, schrieb Alexey Kardashevskiy: > On 11/08/2013 01:01 AM, Andreas F=C3=A4rber wrote: >> Please do separate these global preparations from the actual new ppc >> property. Elsewhere it was discussed whether to use a readable string >> value, which might hint at a dynamic property of type string or maybe >> towards an enum (/me no experience with those yet and whether that wor= ks >> better with dynamic or static). >=20 >=20 > Ufff... I did not get the part about a hint. Everything is string > in the command line :) Your "compat" and "compat1" properties in the previous patch were of type int. :) The question I raised was how to best implement Alex' suggestion of using literal "power6" rather than 206 as value. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg