From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VemNg-0002IK-16 for qemu-devel@nongnu.org; Fri, 08 Nov 2013 08:45:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VemNZ-0002lw-GK for qemu-devel@nongnu.org; Fri, 08 Nov 2013 08:45:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VemNZ-0002ln-4R for qemu-devel@nongnu.org; Fri, 08 Nov 2013 08:45:41 -0500 Message-ID: <527CEAFE.90403@redhat.com> Date: Fri, 08 Nov 2013 06:45:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383881209-24318-1-git-send-email-famz@redhat.com> In-Reply-To: <1383881209-24318-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XalDNwcs4hIkjPLmjJkEheAc8XC7OdtEw" Subject: Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XalDNwcs4hIkjPLmjJkEheAc8XC7OdtEw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/07/2013 08:26 PM, Fam Zheng wrote: > If backing file doesn't exist, the error message is confusing and > misleading: >=20 > $ qemu /tmp/a.qcow2 > qemu: could not open disk image /tmp/a.qcow2: Could not open file: = No > such file or directory >=20 > This is not intuitive. It's better to have the missing file's name in > the error message. With this patch: >=20 > $ qemu-io -c 'read 0 512' /tmp/a.qcow2 > qemu-io: can't open device /tmp/a.qcow2: Could not open backing > file: Could not open '/stor/vm/arch.raw': No such file or directory= > no file open, try 'help open' >=20 > Which is a little bit better. >=20 > Signed-off-by: Fam Zheng >=20 > --- > v2: Don't leak local_err (Eric). Thanks. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XalDNwcs4hIkjPLmjJkEheAc8XC7OdtEw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSfOr+AAoJEKeha0olJ0Nqn/QIAKszVjPPFNB/bYDAQZH6VRkp AmfEjeqcvS2RQMXqV+PnG3RE1+T+R9lufEIHpBEjvYxSHc2ESo/+T6O6GgCl9bdy eUj4TqJ8pK9OD+iLebrh0RbyZIzMuzJ858BWdi67Qd+LhVbRfqESVJK03TcBPnOU 2KBuUXef2FFokefJGmrg3aQKrpUPB/Ji3ahrRcIvUmdCPrA6tk5GAiWZCDMsmQVk u+KL0wzFXFWdkny5TTPVSV+Vi+1j3nbd/fsNRWKRkL6vebuFbrGRMNOohyU/6ZLH uTg/HnxL30XZDjb7ifpXGa4RRI9qMzQP9bUGdr5ynie0KdZXOqv6DvzqAcAaelY= =cPsA -----END PGP SIGNATURE----- --XalDNwcs4hIkjPLmjJkEheAc8XC7OdtEw--