From: Eric Blake <eblake@redhat.com>
To: famz@redhat.com, Xu Wang <cngesaint@gmail.com>
Cc: kwolf@redhat.com, wdongxu@linux.vnet.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, Xu Wang <gesaint@linux.vnet.ibm.com>,
xiawenc@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH V6 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()
Date: Fri, 08 Nov 2013 06:53:27 -0700 [thread overview]
Message-ID: <527CECD7.9020202@redhat.com> (raw)
In-Reply-To: <20131108101940.GB26775@T430s.nay.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
On 11/08/2013 03:19 AM, Fam Zheng wrote:
>
>> + BlockDriverState *bs;
>> + BlockDriver *drv;
>> + char fbuf[1024];
>
> Could use PATH_MAX.
PATH_MAX is undefined on some platforms, and could also be defined to
something larger than a page which could lead to nastiness if you end up
overflowing the stack. I personally prefer malloc'd buffers rather than
attempting to guess at how large to size things, although the rest of
the code base also has similar caps at 1024 so this isn't making it worse.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-11-08 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 3:09 [Qemu-devel] [PATCH V6 0/5] Refine and export backing file loop check Xu Wang
2013-11-06 3:09 ` [Qemu-devel] [PATCH V6 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list() Xu Wang
2013-11-08 10:19 ` Fam Zheng
2013-11-08 13:53 ` Eric Blake [this message]
2013-11-08 14:46 ` Jeff Cody
2013-11-06 3:09 ` [Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open() Xu Wang
2013-11-08 10:21 ` Fam Zheng
2013-11-08 16:19 ` Jeff Cody
2013-11-08 16:27 ` Stefan Weil
2013-11-06 3:09 ` [Qemu-devel] [PATCH V6 3/5] block: Add check infinite loop in bdrv_img_create() Xu Wang
2013-11-08 10:22 ` Fam Zheng
2013-11-06 3:09 ` [Qemu-devel] [PATCH V6 4/5] block: Add backing file loop check in change_backing_file() Xu Wang
2013-11-06 3:09 ` [Qemu-devel] [PATCH V6 5/5] blockdev: Add infinite loop check in drive_init() Xu Wang
2013-11-08 10:26 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CECD7.9020202@redhat.com \
--to=eblake@redhat.com \
--cc=cngesaint@gmail.com \
--cc=famz@redhat.com \
--cc=gesaint@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=wdongxu@linux.vnet.ibm.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.