From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Veoto-0000Bt-Fy for qemu-devel@nongnu.org; Fri, 08 Nov 2013 11:27:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Veoti-0007ei-GL for qemu-devel@nongnu.org; Fri, 08 Nov 2013 11:27:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Veoti-0007eb-8e for qemu-devel@nongnu.org; Fri, 08 Nov 2013 11:27:02 -0500 Message-ID: <527D10C7.40309@redhat.com> Date: Fri, 08 Nov 2013 17:26:47 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1383511723-11228-1-git-send-email-marcel.a@redhat.com> <527D0652.9020805@suse.de> <527D0F29.40802@redhat.com> In-Reply-To: <527D0F29.40802@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Peter Maydell , "Michael S. Tsirkin" , Jan Kiszka , Marcel Apfelbaum , qemu-devel , Anthony Liguori , Jordan Justen , =?ISO-8859-1?Q?Andreas_F=E4rber?= , rth@twiddle.net Il 08/11/2013 17:19, Laszlo Ersek ha scritto: > I'm not very familiar with external files in tests though. Can I model > it on "qdict-test-data.txt"? > > "qdict-test-data.txt" is located in the root source directory. When > configure runs outside the root source directory (= separate build dir), > it symlinks it. And, the "check-qdict.c" test program opens it (with > fopen()) simply by basename (no path prefix). Can I follow that? Yes, tests are always run from the root build directory. Symlinking files is not particularly awesome, but it works. A patch to move qdict-test-data.txt to tests/ is welcome. :) You can create a temporary file as well from the qtest. That's probably easier; just write 64 kB of 0x00 0x01 0x02 0x03...0xFF 0x00 0x01... Also, please test both -bios and -pflash. Paolo