From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172] helo=ns3.lanforge.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VepJc-0000Kq-8e for ath10k@lists.infradead.org; Fri, 08 Nov 2013 16:53:48 +0000 Message-ID: <527D1704.2000508@candelatech.com> Date: Fri, 08 Nov 2013 08:53:24 -0800 From: Ben Greear MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures. References: <1383585574-17779-1-git-send-email-greearb@candelatech.com> <87ppqbb4g0.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87ppqbb4g0.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: ath10k@lists.infradead.org On 11/08/2013 01:58 AM, Kalle Valo wrote: > greearb@candelatech.com writes: > >> From: Ben Greear >> > > I did some changes to this patch: > > https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78 > > The patch is still on ath-next-test branch. Please take a look and if > it's ok for you, send you S-o-b tag so that I can apply it (it was > missing). This part has some grammar issues, it seems to say that the failure is due to changed bssid. Maybe make it instead: Failed to add peer %pM for vdev %d when changing bssid, error: %i - ath10k_warn("Failed to add peer: %pM for VDEV: %d\n", - info->bssid, arvif->vdev_id); + ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n", + info->bssid, arvif->vdev_id, ret); Either way, it's better than what was there before, so: Signed-off-by: Ben Greear -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k