From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Florian Meier <florian.meier-oZ8rN/sblLk@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes
Date: Fri, 08 Nov 2013 09:59:28 -0700 [thread overview]
Message-ID: <527D1870.8080302@wwwdotorg.org> (raw)
In-Reply-To: <527CB3A1.7050808-oZ8rN/sblLk@public.gmane.org>
On 11/08/2013 02:49 AM, Florian Meier wrote:
> In order to find I2C devices in the device tree, the platform nodes
> have to be known by the I2C core. Analogous to the i2c-omap driver
> this requires setting the dev.of_node parameter of the adapter.
(CCing the I2C maintainers...)
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -299,6 +299,7 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
> strlcpy(adap->name, "bcm2835 I2C adapter", sizeof(adap->name));
> adap->algo = &bcm2835_i2c_algo;
> adap->dev.parent = &pdev->dev;
> + adap->dev.of_node = pdev->dev.of_node;
Ah, that makes sense. Thinking about it now, I'd only ever used i2cget
etc. to access I2C devices, rather than instantiating drivers from DT.
That all said, I wonder if the I2C core shouldn't do something like the
following inside i2c_add_adapter():
if (!adap->dev.of_node && adap->dev.parent)
adap->dev.of_node = adap->dev.parent->of_node;
That would save every single I2C driver from having to set up this field
manually.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes
Date: Fri, 08 Nov 2013 09:59:28 -0700 [thread overview]
Message-ID: <527D1870.8080302@wwwdotorg.org> (raw)
In-Reply-To: <527CB3A1.7050808@koalo.de>
On 11/08/2013 02:49 AM, Florian Meier wrote:
> In order to find I2C devices in the device tree, the platform nodes
> have to be known by the I2C core. Analogous to the i2c-omap driver
> this requires setting the dev.of_node parameter of the adapter.
(CCing the I2C maintainers...)
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -299,6 +299,7 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
> strlcpy(adap->name, "bcm2835 I2C adapter", sizeof(adap->name));
> adap->algo = &bcm2835_i2c_algo;
> adap->dev.parent = &pdev->dev;
> + adap->dev.of_node = pdev->dev.of_node;
Ah, that makes sense. Thinking about it now, I'd only ever used i2cget
etc. to access I2C devices, rather than instantiating drivers from DT.
That all said, I wonder if the I2C core shouldn't do something like the
following inside i2c_add_adapter():
if (!adap->dev.of_node && adap->dev.parent)
adap->dev.of_node = adap->dev.parent->of_node;
That would save every single I2C driver from having to set up this field
manually.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Florian Meier <florian.meier@koalo.de>
Cc: linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes
Date: Fri, 08 Nov 2013 09:59:28 -0700 [thread overview]
Message-ID: <527D1870.8080302@wwwdotorg.org> (raw)
In-Reply-To: <527CB3A1.7050808@koalo.de>
On 11/08/2013 02:49 AM, Florian Meier wrote:
> In order to find I2C devices in the device tree, the platform nodes
> have to be known by the I2C core. Analogous to the i2c-omap driver
> this requires setting the dev.of_node parameter of the adapter.
(CCing the I2C maintainers...)
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -299,6 +299,7 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
> strlcpy(adap->name, "bcm2835 I2C adapter", sizeof(adap->name));
> adap->algo = &bcm2835_i2c_algo;
> adap->dev.parent = &pdev->dev;
> + adap->dev.of_node = pdev->dev.of_node;
Ah, that makes sense. Thinking about it now, I'd only ever used i2cget
etc. to access I2C devices, rather than instantiating drivers from DT.
That all said, I wonder if the I2C core shouldn't do something like the
following inside i2c_add_adapter():
if (!adap->dev.of_node && adap->dev.parent)
adap->dev.of_node = adap->dev.parent->of_node;
That would save every single I2C driver from having to set up this field
manually.
next prev parent reply other threads:[~2013-11-08 16:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 9:49 [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes Florian Meier
2013-11-08 9:49 ` Florian Meier
[not found] ` <527CB3A1.7050808-oZ8rN/sblLk@public.gmane.org>
2013-11-08 16:59 ` Stephen Warren [this message]
2013-11-08 16:59 ` Stephen Warren
2013-11-08 16:59 ` Stephen Warren
[not found] ` <527D1870.8080302-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-26 3:31 ` Stephen Warren
2013-11-26 3:31 ` Stephen Warren
2013-11-26 3:31 ` Stephen Warren
2013-11-26 13:05 ` Charles Keepax
2013-11-26 13:05 ` Charles Keepax
2013-11-26 13:05 ` Charles Keepax
[not found] ` <20131126130553.GF25130-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-11-28 17:13 ` Mark Brown
2013-11-28 17:13 ` Mark Brown
2013-11-28 17:13 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-11-25 8:01 Florian Meier
2013-11-25 8:01 ` Florian Meier
[not found] ` <529303EE.4080606-oZ8rN/sblLk@public.gmane.org>
2013-11-25 17:03 ` Stephen Warren
2013-11-25 17:03 ` Stephen Warren
2013-11-26 12:57 ` Wolfram Sang
2013-11-26 12:57 ` Wolfram Sang
2013-11-28 8:50 ` Wolfram Sang
2013-11-28 8:50 ` Wolfram Sang
2013-11-28 8:56 ` Florian Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527D1870.8080302@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=florian.meier-oZ8rN/sblLk@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.