From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VepZB-00025a-Ia for qemu-devel@nongnu.org; Fri, 08 Nov 2013 12:10:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VepZ4-00055x-4p for qemu-devel@nongnu.org; Fri, 08 Nov 2013 12:09:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55380 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VepZ3-00055r-U4 for qemu-devel@nongnu.org; Fri, 08 Nov 2013 12:09:46 -0500 Message-ID: <527D1AD5.10503@suse.de> Date: Fri, 08 Nov 2013 18:09:41 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1383511723-11228-1-git-send-email-marcel.a@redhat.com> <527D0652.9020805@suse.de> <527D0F29.40802@redhat.com> In-Reply-To: <527D0F29.40802@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Peter Maydell , "Michael S. Tsirkin" , Jan Kiszka , Marcel Apfelbaum , qemu-devel , Anthony Liguori , Paolo Bonzini , Jordan Justen , rth@twiddle.net Am 08.11.2013 17:19, schrieb Laszlo Ersek: > On 11/08/13 16:42, Andreas F=E4rber wrote: >> Jordan or Laszlo, >> >> Can either of you please add a small test case to i440fx-test using >> -pflash and doing a read in the PCI hole (or wherever exactly) so that >> we can avoid regressing yet again? :) >=20 > For -pflash we need a small test file. I'm thinking about creating a 51= 2 > byte (1 sector) big file, and modifying the qemu command line in > "tests/i440fx-test.c". >=20 > I'm not very familiar with external files in tests though. Can I model > it on "qdict-test-data.txt"? >=20 > "qdict-test-data.txt" is located in the root source directory. When > configure runs outside the root source directory (=3D separate build di= r), > it symlinks it. And, the "check-qdict.c" test program opens it (with > fopen()) simply by basename (no path prefix). Can I follow that? I don't have personal experience with using external files there yet, but I was hoping that using -pflash pc-bios/bios.bin would just work since that'll be symlinked for execution from build directory iiuc. My thinking was the test could then verify that the BIOS does not read as all 0xff, whereas Paolo's suggestion sounds more elaborate, ruling out actual 0xff within SeaBIOS by having a positive pattern to check for. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg