From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VexGq-0000u5-6p for qemu-devel@nongnu.org; Fri, 08 Nov 2013 20:23:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VexGk-00025K-6U for qemu-devel@nongnu.org; Fri, 08 Nov 2013 20:23:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VexGj-00025E-UV for qemu-devel@nongnu.org; Fri, 08 Nov 2013 20:23:22 -0500 Message-ID: <527D8F2A.2000507@redhat.com> Date: Sat, 09 Nov 2013 02:26:02 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1383955451-20618-1-git-send-email-lersek@redhat.com> In-Reply-To: <1383955451-20618-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] i440fx-test: check firmware visibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, pbonzini@redhat.com, jljusten@gmail.com, afaerber@suse.de, marcel.a@redhat.com On 11/09/13 01:04, Laszlo Ersek wrote: > Laszlo Ersek (4): > i440fx-test: qtest_start() should be paired with qtest_end() > i440fx-test: give each GTest case its own qtest > i440fx-test: generate temporary firmware blob > i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash > > tests/i440fx-test.c | 169 ++++++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 152 insertions(+), 17 deletions(-) Self-NAK I'll have to send a new version, for at least two reasons: - The original code (before patch #1) doesn't bother to free "data.bus" (the retval of qpci_init_pc()). Therefore I assumed this function only grabbed a (non-counted) reference. This is not the case: the original code leaks it (although it exits soon after), and my patch #2 doubles the leak. - There's something fishy with g_assert() firing in the new test case. I end up with a hung qemu process, reparented to init: x86_64-softmmu/qemu-system-x86_64 \ -qtest unix:/tmp/qtest-26926.sock,nowait -qtest-log /dev/null \ -qmp unix:/tmp/qtest-26926.qmp,nowait \ -pidfile /tmp/qtest-26926.pid -machine accel=qtest \ -S -display none -pflash /tmp/fw_blob_553Y5W I have no idea if this has to do with my unorthodox use of "-S" in qtest, or if it's a general shortcoming of qtest (ie. aborting before qtest_end()). Anyway the series should be reviewable as-is, so I'll wait a bit for comments. Thanks! Laszlo