All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>,
	"Kharche, Harshavardhan R" <harshavardhan.r.kharche@intel.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"Rao, Nikhil" <nikhil.rao@intel.com>,
	"Dutt, Sudeep" <sudeep.dutt@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] misc: mic: dead code removal and minor cleanup
Date: Sat, 09 Nov 2013 06:35:24 +0100	[thread overview]
Message-ID: <527DC99C.2060703@free-electrons.com> (raw)
In-Reply-To: <6DC2528F945B4149AB6566DFB5F22ED38AAA142A@ORSMSX109.amr.corp.intel.com>

Hi Ashutosh,

Thanks for your review!

On 11/09/2013 06:06 AM, Dixit, Ashutosh wrote:
> Hi Michael
>
> Thanks for your mail. However, the dead code has resulted from
> another bug in the code, we should be decrementing retry instead
> of i. The same bug occurs in several other places in the code too.
>
> So I would say don't apply this patch. We are planning a series of
> patches to fix other issues in the code when the 3.13 merge window
> closes and will include this fix too and include you in "Reported-by".
That's fine for me. Good to know that this issue is being taken care of.

Thanks for yor work!

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098


      reply	other threads:[~2013-11-09  5:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-09  4:13 [PATCH] misc: mic: dead code removal and minor cleanup Michael Opdenacker
2013-11-09  5:06 ` Dixit, Ashutosh
2013-11-09  5:35   ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527DC99C.2060703@free-electrons.com \
    --to=michael.opdenacker@free-electrons.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=harshavardhan.r.kharche@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.rao@intel.com \
    --cc=sudeep.dutt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.