From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: Fix mag3110 scan_type
Date: Sat, 09 Nov 2013 12:15:24 +0000 [thread overview]
Message-ID: <527E275C.9030503@kernel.org> (raw)
In-Reply-To: <1383008397-8721-1-git-send-email-pmeerw@pmeerw.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/29/13 00:59, Peter Meerwald wrote:
> last argument of IIO_ST is shift, not endianness
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
applied to the fixes-togreg branch of iio.git
Hmm. Really should finish off the removal of that Macro at some point.
When I originally introduced that Arnd Bergman said it was a bad
idea. How right he was ;)
> --- drivers/iio/magnetometer/mag3110.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/mag3110.c b/drivers/iio/magnetometer/mag3110.c index 783c5b4..becf544 100644
> --- a/drivers/iio/magnetometer/mag3110.c +++ b/drivers/iio/magnetometer/mag3110.c @@ -250,7 +250,12 @@ done:
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ) | \ BIT(IIO_CHAN_INFO_SCALE), \ .scan_index = idx, \ -
> .scan_type = IIO_ST('s', 16, 16, IIO_BE), \ + .scan_type = { \ + .sign = 's', \ + .realbits = 16, \ +
> .storagebits = 16, \ + .endianness = IIO_BE, \ + }, \ }
>
> static const struct iio_chan_spec mag3110_channels[] = {
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSfidbAAoJEFSFNJnE9BaIhYUP/3rg0WHJIcuPWP30rT46W1DJ
7EwLkyy25UlfvUmiOqblFit79fqM7ezidAuvGhTJP36H00sMRFLuh0gMCCy2qISF
yKxyj2RfxedQ0AZO9cJFjDc133rSbhhPeyKgtg5jEwHLLSyc5YSVR173PMDa7g90
xuRPwQxIYlBwxwuY2u22nE/L7DeEnrBwVGK1HtHnc2SsWTTCXKekftILtaaqXlko
3SBUwp/zV3TmD2IEH/CYLoquabgt5jY9A3Wdlxw7M3jYdfsUTbJrgJIsDbbviH+E
EhKopNcASnkK7ToI2X/wp2EoQUyGKn392PwnPfHwKhAQ7/D0E9G/DAhK6FIZHvtv
aDSPQ5FRUWJft9cLWT3IjzsmHswjXsqCuTsFur5YI4AYaibslx78Isyu2nNtSMmj
hujVNOvGklnmUygEMhUd4T1D7bt5c2x/7IzCFfUvJo+bywhI0Zxm/92PikToROJu
pgBjhRzCwwnW/GYp7UOshTUFuG0oQvZlo2x0OQDT6fAPTZexVx2fuJzRIjF8hBVw
6E3c/jro0p0fvjWlYgW1H1SaNPiQ8ORP5EQNuGqoympZQSpy2fOnqPtm2gi3DH7C
IVzXez37axNPDtyIP20JyUCCOMHdWjMUOgrYCdPFY9t+M4apXVSqzw9Y6XVhkdI6
YaVAeFlvGfm7b8ktLPBT
=CDMK
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2013-11-09 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 0:59 [PATCH 1/4] iio: Fix mag3110 scan_type Peter Meerwald
2013-10-29 0:59 ` [PATCH 2/4] iio: Fix mag3110 Kconfig dependencies Peter Meerwald
2013-11-09 12:15 ` Jonathan Cameron
2013-10-29 0:59 ` [PATCH 3/4] iio: Fix tcs3472 " Peter Meerwald
2013-11-09 12:16 ` Jonathan Cameron
2013-10-29 0:59 ` [PATCH 4/4] staging:iio: Fix hmc5843 " Peter Meerwald
2013-11-09 12:16 ` Jonathan Cameron
2013-11-09 12:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527E275C.9030503@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.