All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] gpio_led: check gpio_request() return value
Date: Sun, 10 Nov 2013 17:27:39 +0200	[thread overview]
Message-ID: <527FA5EB.7090703@compulab.co.il> (raw)
In-Reply-To: <1383865432-21801-3-git-send-email-grinberg@compulab.co.il>

On 11/08/13 01:03, Igor Grinberg wrote:
> Add a check for the gpio_request() function return value and do not try
> to configure the GPIO if the gpio_request() call fails.
> Also, print an error message indicating the gpio_request() has failed.
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>

Tested-by: Ilya Ledvich <ilya@compulab.co.il>

> ---
>  drivers/misc/gpio_led.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c
> index 3fedddc..de20419 100644
> --- a/drivers/misc/gpio_led.c
> +++ b/drivers/misc/gpio_led.c
> @@ -11,7 +11,11 @@
>  
>  void __led_init(led_id_t mask, int state)
>  {
> -	gpio_request(mask, "gpio_led");
> +	if (gpio_request(mask, "gpio_led") != 0) {
> +		printf("%s: failed requesting GPIO%lu!\n", __func__, mask);
> +		return;
> +	}
> +
>  	gpio_direction_output(mask, state == STATUS_LED_ON);
>  }
>  
> 

-- 
Regards,
Igor.

  reply	other threads:[~2013-11-10 15:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 23:03 [U-Boot] [PATCH 0/3] gpio_led driver updates Igor Grinberg
2013-11-07 23:03 ` [U-Boot] [PATCH 1/3] README: document the CONFIG_GPIO_LED symbol Igor Grinberg
2013-11-25 21:56   ` [U-Boot] [U-Boot, " Tom Rini
2013-11-07 23:03 ` [U-Boot] [PATCH 2/3] gpio_led: check gpio_request() return value Igor Grinberg
2013-11-10 15:27   ` Igor Grinberg [this message]
2013-11-25 21:56   ` [U-Boot] [U-Boot, " Tom Rini
2013-11-07 23:03 ` [U-Boot] [PATCH 3/3] gpio_led: add support for inverted polarity Igor Grinberg
2013-11-10 15:28   ` Igor Grinberg
2013-11-11  1:19   ` Otavio Salvador
2013-11-25 21:56   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527FA5EB.7090703@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.