From: Andi Kleen <ak@linux.intel.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
syzbot <syzbot+84fe685c02cd112a2ac3@syzkaller.appspotmail.com>
Cc: bp@alien8.de, hpa@zytor.com, inglorion@google.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [syzbot] KASAN: stack-out-of-bounds Read in profile_pc
Date: Wed, 2 Jun 2021 16:35:11 -0700 [thread overview]
Message-ID: <527ad07e-eec2-a211-03e7-afafe5196100@linux.intel.com> (raw)
In-Reply-To: <20210602230054.vyqama2q3koc4bpo@treble>
> profile_pc() assumes the return address is either directly at regs->sp,
> or one word adjacent to it due to saved flags, both of which are just
> completely wrong. This code has probably never worked with ORC, and
> nobody noticed apparently.
I presume it used to work because the lock functions were really simple,
but that's not true anymore.
>
> We could just use ORC to unwind to the next frame. Though, isn't
> /proc/profile redundant, compared to all the more sophisticated options
> nowadays? Is there still a distinct use case for it or can we just
> remove it?
It's still needed for some special cases. For example there is no other
viable way to profile early boot without a VM
I would just drop the hack to unwind, at least for the early boot
profile use case locking profiling is usually not needed.
-Andi
next prev parent reply other threads:[~2021-06-02 23:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:15 [syzbot] KASAN: stack-out-of-bounds Read in profile_pc syzbot
2021-06-02 23:00 ` Josh Poimboeuf
2021-06-02 23:35 ` Andi Kleen [this message]
2021-06-03 13:29 ` Josh Poimboeuf
2021-06-03 13:30 ` Peter Zijlstra
2021-06-03 13:39 ` Josh Poimboeuf
2021-06-03 13:52 ` Andi Kleen
2021-10-11 13:07 ` Lee Jones
2021-10-11 14:43 ` Steven Rostedt
2021-10-11 17:10 ` Dmitry Vyukov
2021-10-11 17:30 ` Josh Poimboeuf
2021-06-03 8:02 ` syzbot
2024-08-01 3:16 ` [syzbot] [kernel?] " syzbot
2024-10-27 10:15 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527ad07e-eec2-a211-03e7-afafe5196100@linux.intel.com \
--to=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=inglorion@google.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=syzbot+84fe685c02cd112a2ac3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.