Re: [PATCH V0] ASoC: pxa-ssp: add TISSP mode support

[Qiao Zhou <zhouqiao@marvell.com>]

On 11/10/2013 07:10 PM, Mark Brown wrote:
> On Sun, Nov 10, 2013 at 09:50:21AM +0800, Qiao Zhou wrote:
>> On 11/08/2013 06:19 PM, Mark Brown wrote:
>
>> The SPI/NSM are not used for audio usage, and currently only PSP
>> mode is used pxa-ssp driver. We have the requirement now to support
>> this SSP mode. The benefit is that we don't need to configure
>> detailed timing in transmit/receiving since HW handles it
>> automatically.
>
>> The SSP mode is something like the PCM format for mono stream for
>> voice related scenario. In current audio format definition and
>> pxa-ssp driver implementation, I don't find suitable way to handle
>> it. so I add such SSP-format to differentiate it from PSP mode. Do I
>> make a confusion of SSP mode and audio frame format? please help
>> comment. thanks.
>
> If this is just about programming the hardware better rather than
> changing the externally visible symbols then as Daniel says it should be
> handled transparently by the driver, replacing the current code for
> whatever formats are handled.  Normally the same DAI format should be
> configured for both CODEC and CPU so unless a new format should also be
> used by CODEC drivers the update ought to be internal to the driver.
>
Yes, it should be an improvement of current driver. The format is not a 
new one, and the DSP_A mode is suitable for it. The question here is to 
handle both PSP and SSP mode here. should I pass another parameter here 
to support it?

-- 

Best Regards
Qiao