All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/radeon: activate UVD clocks before sending the destroy msg
Date: Mon, 11 Nov 2013 09:54:14 +0100	[thread overview]
Message-ID: <52809B36.1060406@vodafone.de> (raw)
In-Reply-To: <CADnq5_PSxEycUNe_JsTKuibBzCy-DzocYN6DxqxNA2H_FXifPw@mail.gmail.com>

Am 30.10.2013 15:29, schrieb Alex Deucher:
> On Wed, Oct 30, 2013 at 7:56 AM, Christian König
> <deathsimple@vodafone.de> wrote:
>> From: Christian König <christian.koenig@amd.com>
>>
>> Make sure the UVD clocks are still active before sending
>> the destroy message, otherwise the hw might hang.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Cc: stable@vger.kernel.org
> Both applied!

On which branch? Those two where intended for drm-fixes-3.12, but they 
didn't showed up in 3.12.0.

Could you apply them to drm-fixes-3.12 as well? They prevent hw lockups 
in case of crashed userspace applications and should also go into older 
stable kernels.

Christian.

> Alex
>
>> ---
>>   drivers/gpu/drm/radeon/radeon_uvd.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
>> index 308eff5..a56dfe4 100644
>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
>> @@ -240,6 +240,8 @@ void radeon_uvd_free_handles(struct radeon_device *rdev, struct drm_file *filp)
>>                  if (handle != 0 && rdev->uvd.filp[i] == filp) {
>>                          struct radeon_fence *fence;
>>
>> +                       radeon_uvd_note_usage(rdev);
>> +
>>                          r = radeon_uvd_get_destroy_msg(rdev,
>>                                  R600_RING_TYPE_UVD_INDEX, handle, &fence);
>>                          if (r) {
>> --
>> 1.8.1.2
>>

  reply	other threads:[~2013-11-11  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 11:56 [PATCH 1/2] drm/radeon: activate UVD clocks before sending the destroy msg Christian König
2013-10-30 11:56 ` [PATCH 2/2] drm/radeon: fix UVD destroy IB size Christian König
2013-10-30 14:29 ` [PATCH 1/2] drm/radeon: activate UVD clocks before sending the destroy msg Alex Deucher
2013-11-11  8:54   ` Christian König [this message]
2013-11-11 13:26     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52809B36.1060406@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.