From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uclibc: fix MIPS variables
Date: Mon, 11 Nov 2013 09:19:34 +0000 [thread overview]
Message-ID: <5280A126.4020805@imgtec.com> (raw)
In-Reply-To: <1384095702-5268-1-git-send-email-thomas.petazzoni@free-electrons.com>
On 11/10/2013 03:01 PM, Thomas Petazzoni wrote:
> The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc
> config option should be enabled for a given MIPS architecture
> variant. Therefore, using lower case names doesn't work: they should
> be upper case, to match uClibc config option names. This commit makes
> sure the mips32, mips32r2 and mips64 builds select the appropriate
> uClibc configuration.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Markos Chandras <Markos.Chandras@imgtec.com>
> ---
> package/uclibc/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index 2dbac12..82dd3aa 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -230,9 +230,9 @@ config BR2_UCLIBC_MIPS_ISA
> default 2 if BR2_mips_2
> default 3 if BR2_mips_3
> default 4 if BR2_mips_4
> - default mips32 if BR2_mips_32
> - default mips32r2 if BR2_mips_32r2
> - default mips64 if BR2_mips_64
> + default MIPS32 if BR2_mips_32
> + default MIPS32R2 if BR2_mips_32r2
> + default MIPS64 if BR2_mips_64
>
> config BR2_UCLIBC_SH_TYPE
> string
>
That looks good to me. Thanks for fixing it.
--
markos
prev parent reply other threads:[~2013-11-11 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 15:01 [Buildroot] [PATCH] uclibc: fix MIPS variables Thomas Petazzoni
2013-11-10 21:41 ` Peter Korsgaard
2013-11-11 9:19 ` Markos Chandras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280A126.4020805@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.