Re: [PATCH v3] add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)

[Florian Echtler <floe@butterbrot.org>]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Hello Dmitry,

On 11.11.2013 08:31, Dmitry Torokhov wrote:
> Hi Florian,
> 
> On Wed, Nov 06, 2013 at 03:26:51PM +0100, Florian Echtler wrote:
>> +
>> +	/* max value unknown, but major/minor axis
>> +	 * can never be larger than screen */
>> +	input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR,
>> +		0, SENSOR_RES_X, 0, 0);
>> +	input_set_abs_params(input_dev, ABS_MT_TOUCH_MINOR,
>> +		0, SENSOR_RES_Y, 0, 0);
> 
> If the range is unknown do we really want to specify min/max?
Geometrically speaking, these _are_ the min/max values. I can't say for
sure if the device has a cutoff threshold somewhere, but in terms of
geometric interpretation, I'd say this is correct.

> Also, does the patch below mess up or device or it still works?
I'll test this tomorrow (no access to SUR40 today). If everything works,
should I resubmit my patch with yours included or just tell you that
it's fine?

BR, Florian
-- 
SENT FROM MY DEC VT50 TERMINAL


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]