All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@imgtec.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 09/18] malta: support for coreFPGA6 boards
Date: Mon, 11 Nov 2013 10:32:31 +0000	[thread overview]
Message-ID: <5280B23F.70000@imgtec.com> (raw)
In-Reply-To: <201311102107.41701.marex@denx.de>



On 10/11/13 20:07, Marek Vasut wrote:
> Dear Paul Burton,
>
>> This patch adds support for running on Malta boards using coreFPGA6
>> core cards, including support for the msc01 system controller used
>> with them. The system controller is detected at runtime allowing one
>> U-boot binary to run on a Malta with either.
>>
>> Due to the PCI I/O base differing between Maltas using gt64120 & msc01
>> system controllers, the UART setup is modified slightly. A second UART
>> is added so that there is one pointing at the correct address for each
>> system controller. The Malta board then defines its own
>> default_serial_console function to select the correct one at runtime.
>> The incorrect UART will simply not function.
>>
>> Tested on:
>>    - A coreFPGA6 Malta running interAptiv and proAptiv bitstreams, both
>>      with and without an L2 cache.
>>    - QEMU.
>>
>> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
>> ---
>> Changes in v3:
>>    - rebase atop master
>>    - remove commit message note about not working in QEMU, this does work
>>      in older QEMU versions as noted by Gabor Juhos
>>
>> Changes in v2:
>>    - rebased after malta moved to board/imgtec/malta
>>    - removed unused status variable from msc01_config_access
>> ---
>>   arch/mips/include/asm/malta.h      |  35 ++++++--
>>   board/imgtec/malta/lowlevel_init.S | 164
>> ++++++++++++++++++++++++++++++++++++- board/imgtec/malta/malta.c         |
>> 126 ++++++++++++++++++++++++++-- drivers/pci/Makefile               |   1
>> +
>>   drivers/pci/pci_msc01.c            | 125 ++++++++++++++++++++++++++++
>>   include/configs/malta.h            |   4 +-
>>   include/msc01.h                    | 135 ++++++++++++++++++++++++++++++
>>   include/pci_ids.h                  |   3 +
>>   include/pci_msc01.h                |  17 ++++
>>   9 files changed, 594 insertions(+), 16 deletions(-)
>>   create mode 100644 drivers/pci/pci_msc01.c
>>   create mode 100644 include/msc01.h
>>   create mode 100644 include/pci_msc01.h
>>
>> diff --git a/arch/mips/include/asm/malta.h b/arch/mips/include/asm/malta.h
>> index d4d44a2..0b50a66 100644
>> --- a/arch/mips/include/asm/malta.h
>> +++ b/arch/mips/include/asm/malta.h
>
> You are missing license in some files.
>
> Best regards,
> Marek Vasut
>

Which files? The only files this patch adds are:

   drivers/pci/pci_msc01.c
   include/msc01.h
   include/pci_msc01.h

...and all 3 of them contain GPL-2.0+ SPDX tags.

Thanks,
     Paul

  reply	other threads:[~2013-11-11 10:32 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 11:18 [U-Boot] [PATCH v1+ 00/18] MIPS Malta board support Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 01/18] mips32: detect L1 cache sizes if they're not defined Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 02/18] pcnet: code style cleanup Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 03/18] pcnet: s/le16_to_cpu/cpu_to_le16/ in pcnet_send Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 04/18] pcnet: add cache flushing & invalidation Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 05/18] pcnet: enable the NOUFLO feature Paul Burton
2013-11-10 20:02   ` Marek Vasut
2013-11-11 10:22     ` Paul Burton
2013-11-11 13:30       ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v2 06/18] pci.h: allow inclusion in assembly source Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v4 07/18] qemu-malta: rename to just "malta" Paul Burton
2013-11-09  0:53   ` Daniel Schwierzeck
2013-11-09 10:22     ` [U-Boot] [PATCH v5 " Paul Burton
2013-11-10 20:05       ` Marek Vasut
2013-11-11 10:24         ` Paul Burton
2013-11-11 13:30           ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v3 08/18] malta: setup super I/O UARTs Paul Burton
2013-11-10 20:06   ` Marek Vasut
2013-11-11 10:29     ` Paul Burton
2013-11-11 13:31       ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v3 09/18] malta: support for coreFPGA6 boards Paul Burton
2013-11-10 20:07   ` Marek Vasut
2013-11-11 10:32     ` Paul Burton [this message]
2013-11-11 10:52       ` Daniel Schwierzeck
2013-11-11 11:03         ` [U-Boot] [PATCH] malta: arch/mips/include/asm/malta.h SPDX license tag Paul Burton
2013-11-11 11:34           ` Daniel Schwierzeck
2013-11-08 11:18 ` [U-Boot] [PATCH v3 10/18] malta: display "U-boot" on the LCD screen Paul Burton
2013-11-10 20:08   ` Marek Vasut
2013-11-11 10:36     ` Paul Burton
2013-11-11 13:32       ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v2 11/18] malta: enable CONFIG_PCNET_79C973, PCNET_HAS_PROM, CONFIG_CMD_DHCP Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 12/18] malta: remove cache size definitions Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v3 13/18] malta: disable L2 caches Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 14/18] malta: enable RTC support Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH 15/18] malta: store environment in flash Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH 16/18] malta: setup PIIX4 interrupt route Paul Burton
2013-11-10 20:09   ` Marek Vasut
2013-11-11 10:57     ` Paul Burton
2013-11-11 13:33       ` Marek Vasut
2013-11-11 13:59         ` Paul Burton
2013-11-11 14:01           ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v3 17/18] malta: add script & instructions to flash U-boot Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v3 18/18] malta: add myself to maintainers Paul Burton
2013-11-09 20:44 ` [U-Boot] [PATCH v1+ 00/18] MIPS Malta board support Daniel Schwierzeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5280B23F.70000@imgtec.com \
    --to=paul.burton@imgtec.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.