From: Jeff Liu <jeff.liu@oracle.com>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
xfs@oss.sgi.com
Cc: vasily.isaenko@oracle.com
Subject: Re: [PATCH] xfstests: generic/273: use src/feature -o
Date: Mon, 11 Nov 2013 19:10:43 +0800 [thread overview]
Message-ID: <5280BB33.4000508@oracle.com> (raw)
In-Reply-To: <1384162494-17002-1-git-send-email-stanislav.kholmanskikh@oracle.com>
On 11/11, 2013 17:34 PM, Stanislav Kholmanskikh wrote:
> Due to partially committed series (fd080d64b6e9677cb9d0a15dc7e308b6ca0e273f)
> generic/273 test uses '_no_of_online_cpus' function which is not defined.
>
> Now it's safe to switch it to 'src/feature -o'.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
> tests/generic/273 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/generic/273 b/tests/generic/273
> index c028438..ab04dfa 100755
> --- a/tests/generic/273
> +++ b/tests/generic/273
> @@ -47,7 +47,7 @@ count=2
>
> _threads_set()
> {
> - _cpu_num=`_no_of_online_cpus`
> + _cpu_num=`$here/src/feature -o`
> threads=$(($_cpu_num * 50))
> if [ $threads -gt 200 ]
> then
Looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-11 11:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:58 Avoid of using /proc/cpuinfo in generic tests Stanislav Kholmanskikh
2013-10-23 11:58 ` [PATCH 1/2] xfstests: implemented _no_of_online_cpus() function Stanislav Kholmanskikh
2013-10-23 13:08 ` Carlos Maiolino
2013-10-23 21:31 ` Dave Chinner
2013-10-24 8:56 ` [PATCH] xfstests: src/feature.c: print a number of online CPUs Stanislav Kholmanskikh
2013-10-24 10:40 ` Dave Chinner
2013-10-24 12:10 ` [PATCH V2] " Stanislav Kholmanskikh
2013-10-28 22:15 ` Dave Chinner
2013-10-29 10:03 ` [PATCH V3] " Stanislav Kholmanskikh
2013-11-05 12:41 ` Stanislav Kholmanskikh
2013-11-10 1:19 ` Rich Johnston
2013-11-10 1:20 ` Rich Johnston
2013-10-24 13:18 ` [PATCH] " Carlos Maiolino
2013-10-24 14:33 ` Stanislav Kholmanskikh
2013-10-24 21:23 ` Dave Chinner
2013-10-28 7:23 ` Stanislav Kholmanskikh
2013-10-28 12:23 ` Carlos Maiolino
2013-10-23 11:58 ` [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo Stanislav Kholmanskikh
2013-10-23 13:09 ` Carlos Maiolino
2013-10-24 0:14 ` Rich Johnston
2013-10-24 1:09 ` Dave Chinner
2013-11-11 9:34 ` [PATCH] xfstests: generic/273: use src/feature -o Stanislav Kholmanskikh
2013-11-11 11:10 ` Jeff Liu [this message]
2013-11-11 16:05 ` Rich Johnston
2013-11-11 16:06 ` Rich Johnston
2013-11-11 14:50 ` [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280BB33.4000508@oracle.com \
--to=jeff.liu@oracle.com \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.