From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v1 6/6] Driver/IFC: Move Freescale IFC driver to a common driver
Date: Mon, 11 Nov 2013 16:43:58 +0530 [thread overview]
Message-ID: <5280BBF6.7080400@freescale.com> (raw)
In-Reply-To: <1383958840.23598.241.camel@snotra.buserror.net>
On 11/9/2013 6:30 AM, Scott Wood wrote:
> On Sat, 2013-11-09 at 06:22 +0530, Prabhakar Kushwaha wrote:
>> On 11/9/2013 6:14 AM, Scott Wood wrote:
>>> On Thu, 2013-10-31 at 08:57 +0530, Prabhakar Kushwaha wrote:
>>>> On 10/31/2013 7:37 AM, York Sun wrote:
>>>>> Freescale IFC controller has been used for mpc8xxx. It will be used
>>>>> for ARM-based SoC as well. This patch moves the driver to driver/mtd
>>>>> and fix the header file includes.
>>>>>
>>>>> Signed-off-by: York Sun <yorksun@freescale.com>
>>>>>
>>>> Thanks York for this patch. This was pending from long time.
>>>>
>>>> This patch moves fsl_ifc.c from powerpc to driver/mtd
>>>> I am not sure having 2 files for IFC controller in driver/mtd/ is
>>>> correct. Although fsl_ifc.c is for IFC Controller(NOR, NAND machine) and
>>>> fsl_ifc_nand.c is only for IFC - NAND machine.
>>>> I am asking this question as same changes will be applicable in Linux also.
>>>>
>>>> Also,
>>>> We have to move changes of arch/powerpc/cpu/mpc85xx/speed.c to fsl_ifc.c
>>>> . This will make a IFC driver generic.
>>>>
>>>> As this patch has impact on all IFC platforms, has this been tested on
>>>> few platforms?
>>> I'm not sure that drivers/mtd is the right place for it as it doesn't
>>> expose an mtd interface.
>>>
>>>
>> Yes Scott, I am also agree with you. But we are not sure about the right
>> place for it.
> This is similar to the question of where to put CPM/QE code. A place
> will need to be identified for glue code that doesn't fit cleanly into
> an existing subsystem. drivers/misc is probably the right place, though
> IIRC on the Linux side the drivers/misc maintainer was generally opposed
> to its existence and pushed back on new things being added to it.
looks like putting fsl_ifc.c in driver/mtd is not good way of handle it.
I should sent on RFC of putting this in driver/misc for Linux and see
the response. May be I get a better solution there.
Regards,
Prabhakar
prev parent reply other threads:[~2013-11-11 11:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 2:07 [U-Boot] [Patch v1 0/6] Move Freescale DDR and IFC drivers to common drivers York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 1/6] Driver/DDR: Moving Freescale DDR driver to a common driver York Sun
2013-11-09 0:48 ` Scott Wood
2013-11-09 2:25 ` york sun
2013-11-11 18:49 ` Scott Wood
2013-11-11 19:05 ` York Sun
2013-11-11 19:35 ` Scott Wood
2013-11-11 19:37 ` York Sun
2013-11-11 19:59 ` Scott Wood
2013-11-11 20:15 ` York Sun
2013-11-11 20:25 ` Scott Wood
2013-10-31 2:07 ` [U-Boot] [Patch v1 2/6] Driver/DDR: combine ccsr_ddr for 83xx, 85xx and 86xx York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 3/6] Driver/DDR: Add Freescale DDR driver for ARM York Sun
2013-11-09 0:51 ` Scott Wood
2013-11-09 2:29 ` york sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 4/6] powerpc/mpc8xxx: Extend DDR registers' fields York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 5/6] Driver/DDR: Update DDR driver to allow non-zero base address York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 6/6] Driver/IFC: Move Freescale IFC driver to a common driver York Sun
2013-10-31 3:27 ` Prabhakar Kushwaha
2013-11-09 0:44 ` Scott Wood
2013-11-09 0:52 ` Prabhakar Kushwaha
2013-11-09 1:00 ` Scott Wood
2013-11-11 11:13 ` Prabhakar Kushwaha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280BBF6.7080400@freescale.com \
--to=prabhakar@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.