From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Quadros <rogerq@ti.com>
Date: Mon, 11 Nov 2013 15:57:22 +0200
Subject: [U-Boot] [PATCH 2/5] ARM: OMAP5: Add Pipe3 PHY driver
In-Reply-To: <20131111135238.GN5925@bill-the-cat>
References: <1383749246-30895-1-git-send-email-rogerq@ti.com>
	<1383749246-30895-3-git-send-email-rogerq@ti.com>
	<527AB930.40509@ti.com> <527B8644.4080801@ti.com>
	<20131111135238.GN5925@bill-the-cat>
Message-ID: <5280E242.4030800@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/11/2013 03:52 PM, Tom Rini wrote:
> On Thu, Nov 07, 2013 at 02:23:32PM +0200, Roger Quadros wrote:
>> On 11/06/2013 11:48 PM, Tom Rini wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 11/06/2013 09:47 AM, Roger Quadros wrote:
>>>> Pipe3 PHY is used by SATA, USB3 and PCIe modules. This is
>>>> a driver for the Pipe3 PHY.
>>>>
>>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> [snip]
>>>> +#define perror(fmt, args...) printf("%s: " fmt, __func__ , ##args)
>>>
>>> Please use the debug macro.
>>>
>> But I want the message to be printed and not hidden if DEBUG is not defined.
> 
> Then just call printf please.  Or is this kernel-adapted code?

OK. No this isn't in the kernel.

> 
>>> [snip[
>>>> +	perror("%s: No DPLL configuration for %u Hz SYS CLK\n",
>>>> +							__func__, rate);
>>>
>>> Indent is wrong, we do like the kernel (and checkpatch.pl is in tools/
>>> and will catch these).  Thanks.
>>
>> you mean the function arguments '__func__' and 'rate' should be on the
>> same line where perror is?
> 
> perror("....\n",
>        __func_, ...);
> 

OK. I'll wait some more time for comments on v2 before I send out a v3 with these changes.

cheers,
-roger