All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@imgtec.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] malta: use unmapped flash base address
Date: Mon, 11 Nov 2013 14:22:41 +0000	[thread overview]
Message-ID: <5280E831.30506@imgtec.com> (raw)
In-Reply-To: <1384178759-19034-1-git-send-email-juhosg@openwrt.org>

On 11/11/13 14:05, Gabor Juhos wrote:
> The physical base address of the NOR flash is 0x1e000000
> on the Malta boards. The hardware also maps the first 4MiB
> of the flash into the 0x1fc00000-0x1fffffff range.
>
> Currently, U-Boot uses the mapped address to access the
> flash, which does not work in recent qemu versions.
>
> Since commit a427338b222b43197c2776cbc996936df0302f51
> (mips_malta: correct reading MIPS revision at 0x1fc00010)
> writing to the mapped address space causes a CPU exception.
> Due to the exception, U-Boot hangs during boot when it tries
> to detect the CFI flash chip.
>
> Use the correct physical address for the MALTA_FLASH_BASE
> constant to avoid the problem. The change makes it possible
> to start U-Boot on a Malta board emulated with Qemu 1.6.1
> and 1.7.0-rc0. It also works on older versions (tested with
> 1.1.1, 1.2.2, 1.4.2, 1.5.3). The change is not tested on a
> real Malta board.
>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Paul Burton <paul.burton@imgtec.com>
> ---
>   arch/mips/include/asm/malta.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/malta.h b/arch/mips/include/asm/malta.h
> index 9b1100b..bd9043d 100644
> --- a/arch/mips/include/asm/malta.h
> +++ b/arch/mips/include/asm/malta.h
> @@ -44,7 +44,7 @@
>   #define MALTA_RESET_BASE		0x1f000500
>   #define GORESET				0x42
>
> -#define MALTA_FLASH_BASE		0x1fc00000
> +#define MALTA_FLASH_BASE		0x1e000000
>
>   #define MALTA_REVISION			0x1fc00010
>   #define MALTA_REVISION_CORID_SHF	10
>

Hmm, this does run on a real Malta but it takes around a minute to run 
relocate_code... With the 0x1fc00000 base address it's much faster. I'll 
see if I can figure out why...

Paul

  reply	other threads:[~2013-11-11 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 14:05 [U-Boot] [PATCH] malta: use unmapped flash base address Gabor Juhos
2013-11-11 14:22 ` Paul Burton [this message]
2013-11-11 18:58   ` Gabor Juhos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5280E831.30506@imgtec.com \
    --to=paul.burton@imgtec.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.